Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2554883002: Reintroduce cloud print build artifacts. (Closed)

Created:
4 years ago by pastarmovj
Modified:
4 years ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reintroduce cloud print build artifacts. This reverts commit 21c970ff0a15072e87d12473f64f0c6937acf7f1. BUG=629512 TEST=none Committed: https://crrev.com/b91e752ebb2677f75c22a32e668059ec99cfd7ac Cr-Commit-Position: refs/heads/master@{#436592}

Patch Set 1 : Uneditted revert of the original commit. #

Patch Set 2 : Remove non-existing targets and limit to 64bits only. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pastarmovj
Please review. Thanks!
4 years ago (2016-12-06 14:02:50 UTC) #2
grt (UTC plus 2)
lgtm
4 years ago (2016-12-06 14:18:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554883002/20001
4 years ago (2016-12-06 14:22:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 14:36:30 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-06 14:38:23 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b91e752ebb2677f75c22a32e668059ec99cfd7ac
Cr-Commit-Position: refs/heads/master@{#436592}

Powered by Google App Engine
This is Rietveld 408576698