Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2554863002: Cleanup remaining class/struct fwd declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, binji+watch_chromium.org, johnme+watch_chromium.org, yzshen+watch_chromium.org, pennymac+watch_chromium.org, agrieve+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, mac-reviews_chromium.org, Peter Beverloo, huangs+watch_chromium.org, oshima+watch_chromium.org, darin (slow to review), Dirk Pranke, tfarina, Aaron Boodman, pfeldman, wfh+watch_chromium.org, cc-bugs_chromium.org, jln+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup remaining class/struct fwd declarations Remove remaining useless class and struct forward declarations from Chromium (excluding third_party directory) using a homemade script available in bug 662195 comments. An up-and-running presubmit check is now available and should prevent new useless forward declarations to come up. BUG=662195 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_nacl_sdk Committed: https://crrev.com/db24b9e6852589972bda0bcf06019024ef1fe2c7 Cr-Commit-Position: refs/heads/master@{#436883}

Patch Set 1 #

Patch Set 2 : Fix ios build + rebase on top of master #

Patch Set 3 : Style fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -172 lines) Patch
M apps/app_lifetime_monitor.h View 1 chunk +0 lines, -4 lines 0 comments Download
M apps/ui/views/app_window_frame_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/in_process_context_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/proxy_main.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M courgette/courgette.h View 1 chunk +0 lines, -1 line 0 comments Download
M courgette/disassembler_elf_32_arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M courgette/disassembler_elf_32_x86.h View 1 chunk +0 lines, -1 line 0 comments Download
M courgette/disassembler_win32_x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M courgette/disassembler_win32_x86.h View 1 chunk +0 lines, -1 line 0 comments Download
M crypto/nss_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M dbus/bus.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gin/function_template.h View 1 chunk +0 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.h View 1 chunk +0 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.h View 1 chunk +0 lines, -4 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M google_apis/gcm/base/mcs_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gcm/engine/connection_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_main_parts.h View 1 chunk +0 lines, -1 line 0 comments Download
M headless/lib/browser/headless_content_browser_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_devtools_manager_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M headless/lib/browser/headless_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.h View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M headless/lib/headless_content_main_delegate.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M headless/public/util/deterministic_http_protocol_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M headless/public/util/http_url_fetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M headless/public/util/in_memory_request_job.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M headless/public/util/testing/generic_url_request_mocks.h View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M ipc/handle_win.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ipc/ipc_channel_nacl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_message.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_message_pipe_reader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/login.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_control_message.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/test/multiprocess_test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/native_struct_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/devfs/dev_fs.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/devfs/jspipe_node.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/fs_factory.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_intercept.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/socket/tcp_event_emitter.h View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/socket/unix_event_emitter.h View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/stream/stream_fs.h View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_host_resolver_interface.h View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_net_address_interface.h View 1 chunk +0 lines, -1 line 0 comments Download
M pdf/pdf_engine.h View 1 chunk +0 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing_context_chromeos.h View 1 chunk +0 lines, -4 lines 0 comments Download
M printing/printing_context_linux.h View 1 chunk +0 lines, -4 lines 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 chunk +0 lines, -4 lines 0 comments Download
M rlz/chromeos/lib/rlz_value_store_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_forward.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/src/broker_services.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/target_process.h View 1 chunk +0 lines, -1 line 0 comments Download
M skia/ext/platform_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M skia/ext/skia_trace_memory_dump_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M skia/ext/skia_utils_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/CheckFieldsVisitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/config_values_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/deps_iterator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/filesystem_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/functions.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/header_checker.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/ninja_build_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/ninja_copy_target_writer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/ninja_target_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/ninja_toolchain_writer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/ninja_writer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/scope.h View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/gn/target.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/xcode_writer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/android/screen_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/mus/pointer_watcher_event_router2.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
jbriance
4 years ago (2016-12-06 13:39:32 UTC) #4
Sam Clegg
On 2016/12/06 13:39:32, jbriance wrote: native_client_sdk lgtm, but can you add CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk?
4 years ago (2016-12-06 18:35:23 UTC) #5
brettw
lgtm
4 years ago (2016-12-06 18:48:54 UTC) #6
jbriance
On 2016/12/06 18:35:23, Sam Clegg wrote: > native_client_sdk lgtm, but can you add > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk? ...
4 years ago (2016-12-06 19:41:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554863002/40001
4 years ago (2016-12-07 07:00:26 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-07 07:07:22 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-07 07:09:40 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/db24b9e6852589972bda0bcf06019024ef1fe2c7
Cr-Commit-Position: refs/heads/master@{#436883}

Powered by Google App Engine
This is Rietveld 408576698