pkg/barback/test/transformer/check_content_and_rename.dart - Issue 255483002: Expand barback's notion of dirtiness to understand declaredness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/barback/test/transformer/check_content_and_rename.dart

Issue 255483002: Expand barback's notion of dirtiness to understand declaredness. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/barback/test/package_graph/lazy_transformer_test.dart ('k') | pkg/barback/test/transformer/declaring_check_content_and_rename.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/barback/test/transformer/check_content_and_rename.dart

diff --git a/pkg/barback/test/transformer/check_content_and_rename.dart b/pkg/barback/test/transformer/check_content_and_rename.dart

index 6d690e40fcb3e8855ffd4b9ebeb7fa20c68cb220..dffad3798e39f296680c754bfd79ecbc9decb8a4 100644

--- a/pkg/barback/test/transformer/check_content_and_rename.dart

+++ b/pkg/barback/test/transformer/check_content_and_rename.dart

@@ -18,10 +18,15 @@ class CheckContentAndRenameTransformer extends MockTransformer {

final String newExtension;

final String newContent;

- CheckContentAndRenameTransformer(this.oldExtension, this.oldContent,

- this.newExtension, this.newContent);

+ CheckContentAndRenameTransformer({this.oldExtension, this.oldContent,

+ this.newExtension, this.newContent}) {

+ assert(oldExtension != null);

+ assert(oldContent != null);

+ assert(newExtension != null);

+ assert(newContent != null);

+ }

- bool doIsPrimary(AssetId id) => id.extension != '.$oldExtension';

+ bool doIsPrimary(AssetId id) => id.extension == '.$oldExtension';

Future doApply(Transform transform) {

return getPrimary(transform).then((input) {