Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2093)

Unified Diff: pkg/barback/lib/src/phase_input.dart

Issue 255483002: Expand barback's notion of dirtiness to understand declaredness. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/lib/src/phase.dart ('k') | pkg/barback/lib/src/transform_node.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/phase_input.dart
diff --git a/pkg/barback/lib/src/phase_input.dart b/pkg/barback/lib/src/phase_input.dart
index 8b9f1dafa477a2543ff8a73dc832fbe3e0fff850..929e96740d6cd63c405e0999f6b6829f971460fc 100644
--- a/pkg/barback/lib/src/phase_input.dart
+++ b/pkg/barback/lib/src/phase_input.dart
@@ -9,6 +9,7 @@ import 'dart:async';
import 'asset_forwarder.dart';
import 'asset_node.dart';
import 'log.dart';
+import 'node_status.dart';
import 'node_streams.dart';
import 'phase.dart';
import 'transform_node.dart';
@@ -43,21 +44,25 @@ class PhaseInput {
/// The streams exposed by this input.
final _streams = new NodeStreams();
- Stream get onDone => _streams.onDone;
+ Stream get onStatusChange => _streams.onStatusChange;
Stream<AssetNode> get onAsset => _streams.onAsset;
Stream<LogEntry> get onLog => _streams.onLog;
- /// Whether [this] is dirty and still has more processing to do.
- bool get isDirty => (input.state.isDirty && !input.deferred) ||
- _transforms.any((transform) => transform.isDirty);
+ /// How far along [this] is in processing its assets.
+ NodeStatus get status {
+ var status = input.state.isDirty && !input.deferred ?
+ NodeStatus.MATERIALIZING : NodeStatus.IDLE;
+ return status.dirtier(NodeStatus.dirtiest(
+ _transforms.map((transform) => transform.status)));
+ }
PhaseInput(this._phase, AssetNode input, this._location)
: _inputForwarder = new AssetForwarder(input) {
_inputSubscription = input.onStateChange.listen((state) {
if (state.isRemoved) {
remove();
- } else if (state.isAvailable) {
- if (!isDirty) _streams.onDoneController.add(null);
+ } else {
+ _streams.changeStatus(status);
}
});
}
@@ -86,9 +91,9 @@ class PhaseInput {
_phase, transformer, input, _location);
_transforms.add(transform);
- transform.onDone.listen((_) {
- if (!isDirty) _streams.onDoneController.add(null);
- }, onDone: () => _transforms.remove(transform));
+ transform.onStatusChange.listen(
+ (_) => _streams.changeStatus(status),
+ onDone: () => _transforms.remove(transform));
_streams.onAssetPool.add(transform.onAsset);
_streams.onLogPool.add(transform.onLog);
« no previous file with comments | « pkg/barback/lib/src/phase.dart ('k') | pkg/barback/lib/src/transform_node.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698