Expand barback's notion of dirtiness to understand declaredness.

pkg/barback/test/transformer/check_content_and_rename.dart

Index: pkg/barback/test/transformer/check_content_and_rename.dart
diff --git a/pkg/barback/test/transformer/check_content_and_rename.dart b/pkg/barback/test/transformer/check_content_and_rename.dart
index 6d690e40fcb3e8855ffd4b9ebeb7fa20c68cb220..235ba0131988ff86107ad3dd6a9967502aa42c11 100644
--- a/pkg/barback/test/transformer/check_content_and_rename.dart
+++ b/pkg/barback/test/transformer/check_content_and_rename.dart
@@ -21,7 +21,7 @@ class CheckContentAndRenameTransformer extends MockTransformer {
   CheckContentAndRenameTransformer(this.oldExtension, this.oldContent,
       this.newExtension, this.newContent);

[Bob Nystrom, 2014/04/25 22:02:33]

These would be easier to read at callsites if they were named parameters.

[nweiz, 2014/04/28 21:02:00]

I'm not sure what the defaults would be...

[Bob Nystrom, 2014/04/29 18:34:43]

I would treat them as non-optional and assert the args are non-null. It's really
just to get the parameter name there, similar to how we handle boolean params.

[nweiz, 2014/04/29 20:11:26]

Done.

 
-  bool doIsPrimary(AssetId id) => id.extension != '.$oldExtension';
+  bool doIsPrimary(AssetId id) => id.extension == '.$oldExtension';
 
   Future doApply(Transform transform) {
     return getPrimary(transform).then((input) {