Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: pkg/barback/lib/src/group_runner.dart

Issue 255483002: Expand barback's notion of dirtiness to understand declaredness. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/barback/lib/src/group_runner.dart
diff --git a/pkg/barback/lib/src/group_runner.dart b/pkg/barback/lib/src/group_runner.dart
index 589370f2a197eb949e7f571065804ba9e7379310..e17f7fe871595326c3ef11172c751dad7f604dc8 100644
--- a/pkg/barback/lib/src/group_runner.dart
+++ b/pkg/barback/lib/src/group_runner.dart
@@ -9,6 +9,7 @@ import 'dart:async';
import 'asset_cascade.dart';
import 'asset_node.dart';
import 'log.dart';
+import 'node_status.dart';
import 'phase.dart';
import 'stream_pool.dart';
import 'transformer_group.dart';
@@ -26,19 +27,16 @@ class GroupRunner {
/// The phases defined by this group.
final _phases = new List<Phase>();
- /// Whether [this] is dirty and still has more processing to do.
- bool get isDirty {
+ /// How far along [this] is in processing its assets.
+ NodeStatus get status {
// Just check the last phase, since it will check all the previous phases
// itself.
- return _phases.last.isDirty;
+ return _phases.last.status;
}
- /// A stream that emits an event whenever [this] is no longer dirty.
- ///
- /// This is synchronous in order to guarantee that it will emit an event as
- /// soon as [isDirty] flips from `true` to `false`.
- Stream get onDone => _onDone;
- Stream _onDone;
+ /// A stream that emits an event every time the group's status changes.
+ Stream<NodeStatus> get onStatusChange => _onStatusChange;
+ Stream _onStatusChange;
/// A stream that emits any new assets emitted by [this].
///
@@ -59,7 +57,7 @@ class GroupRunner {
}
_onAsset = _phases.last.onAsset;
- _onDone = _phases.last.onDone;
+ _onStatusChange = _phases.last.onStatusChange;
}
/// Add a phase with [contents] to [this]'s list of phases.

Powered by Google App Engine
This is Rietveld 408576698