Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2554813004: Revert "Do not remove floating legend from inner block as it gets destroyed somewhere else." (Closed)

Created:
4 years ago by Gleb Lanbin
Modified:
4 years ago
Reviewers:
cbiesinger
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Do not remove floating legend from inner block as it gets destroyed somewhere else." This reverts commit 71ac9500f1ad978a5459991592c2d3a193b219d7. Reason for revert: broke real world websites. BUG=670837 Committed: https://crrev.com/d4b651adfd8d42052ee0c7967a18f6a29ba3524f Cr-Commit-Position: refs/heads/master@{#436664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 2 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Gleb Lanbin
4 years ago (2016-12-06 17:26:42 UTC) #5
cbiesinger
lgtm
4 years ago (2016-12-06 17:27:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554813004/1
4 years ago (2016-12-06 17:37:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 18:53:14 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-06 18:56:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4b651adfd8d42052ee0c7967a18f6a29ba3524f
Cr-Commit-Position: refs/heads/master@{#436664}

Powered by Google App Engine
This is Rietveld 408576698