Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2554803003: Redirect links to faster-builds tips to newly merged Linux instructions (Closed)

Created:
4 years ago by amoylan
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Redirect links to faster-builds tips to newly merged Linux instructions The tips on faster Linux builds got merged into the general Linux build instructions. But there were a couple of links to the now-deleted old tips page. I've added a named anchor inside the merged instructions and redirected one link there. The other link was a self-link and I removed it. BUG= Committed: https://crrev.com/a6db977a99fdf76af5f95a03c1ca41b72bf763f6 Cr-Commit-Position: refs/heads/master@{#437141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M docs/common_build_tasks.md View 1 chunk +2 lines, -1 line 0 comments Download
M docs/linux_build_instructions.md View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
amoylan
Hi! This my first Chromium CL.
4 years ago (2016-12-07 04:24:46 UTC) #5
Dirk Pranke
lgtm, thanks! And welcome! Much of common_build_tasks is out of date and should probably be ...
4 years ago (2016-12-07 18:42:03 UTC) #8
amoylan
On 2016/12/07 18:42:03, Dirk Pranke wrote: > lgtm, thanks! > > And welcome! > > ...
4 years ago (2016-12-07 23:39:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554803003/1
4 years ago (2016-12-07 23:40:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 02:09:20 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-08 02:12:32 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6db977a99fdf76af5f95a03c1ca41b72bf763f6
Cr-Commit-Position: refs/heads/master@{#437141}

Powered by Google App Engine
This is Rietveld 408576698