Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25548007: [NaCl Docs] Add a new doc build configuration: devsite-staging. (Closed)

Created:
7 years, 2 months ago by Sam Clegg
Modified:
7 years, 2 months ago
Reviewers:
eliben
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji
Visibility:
Public.

Description

[NaCl Docs] Add a new doc build configuration: devsite-staging. In this mode the html files expect to live under a folder called $USER which allows each of us to stage our own copy of the docs. In order to implement this I added a new devsite config option called devsite_foldername which defaults to 'dev'. R=eliben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226532

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+679 lines, -33 lines) Patch
M native_client_sdk/src/doc/Makefile View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/README View 1 2 1 chunk +20 lines, -22 lines 0 comments Download
A native_client_sdk/src/doc/_book.yaml View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/_project.yaml View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/_reference_toc.yaml View 1 2 3 1 chunk +494 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/_sphinxext/devsite_builder.py View 1 2 3 7 chunks +62 lines, -10 lines 0 comments Download
A native_client_sdk/src/doc/community/_toc.yaml View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/_toc.yaml View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/coding/_toc.yaml View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/message-system.rst View 1 chunk +1 line, -1 line 2 comments Download
A native_client_sdk/src/doc/devguide/devcycle/_toc.yaml View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/sdk/_toc.yaml View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sam Clegg
7 years, 2 months ago (2013-10-02 00:12:45 UTC) #1
eliben
https://codereview.chromium.org/25548007/diff/6001/native_client_sdk/src/doc/Makefile File native_client_sdk/src/doc/Makefile (right): https://codereview.chromium.org/25548007/diff/6001/native_client_sdk/src/doc/Makefile#newcode8 native_client_sdk/src/doc/Makefile:8: BUILDDIR = _build Mention USER here? https://codereview.chromium.org/25548007/diff/6001/native_client_sdk/src/doc/_sphinxext/devsite_builder.py File native_client_sdk/src/doc/_sphinxext/devsite_builder.py ...
7 years, 2 months ago (2013-10-02 15:57:32 UTC) #2
Sam Clegg
Updated image links and made left have tree nav work. This required adding the yaml ...
7 years, 2 months ago (2013-10-02 19:08:07 UTC) #3
Sam Clegg
https://codereview.chromium.org/25548007/diff/12001/native_client_sdk/src/doc/devguide/coding/message-system.rst File native_client_sdk/src/doc/devguide/coding/message-system.rst (left): https://codereview.chromium.org/25548007/diff/12001/native_client_sdk/src/doc/devguide/coding/message-system.rst#oldcode148 native_client_sdk/src/doc/devguide/coding/message-system.rst:148: <body {{attrs}}> Devsite can't handle {{ or }} even ...
7 years, 2 months ago (2013-10-02 19:09:12 UTC) #4
eliben
lgtm https://codereview.chromium.org/25548007/diff/12001/native_client_sdk/src/doc/devguide/coding/message-system.rst File native_client_sdk/src/doc/devguide/coding/message-system.rst (right): https://codereview.chromium.org/25548007/diff/12001/native_client_sdk/src/doc/devguide/coding/message-system.rst#newcode148 native_client_sdk/src/doc/devguide/coding/message-system.rst:148: <body {attrs}> I think it's because these are ...
7 years, 2 months ago (2013-10-02 19:39:25 UTC) #5
Sam Clegg
7 years, 2 months ago (2013-10-02 19:45:09 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 manually as r226532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698