Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2554753004: Revert of [Devtools] Moved flatten children to children nodes instead of datagrid (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
dgozman, allada
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Devtools] Moved flatten children to children nodes instead of datagrid (patchset #4 id:100001 of https://codereview.chromium.org/2540543002/ ) Reason for revert: Broke timeline tree view. BUG=671487 Original issue's description: > [Devtools] Moved flatten children to children nodes instead of datagrid > > This patch moves the flattenNodeList() and renames it flattenChildren() to > be more appropriate. It is also moves it to the nodes instead of the > DataGrid. > > R=dgozman > BUG=None > > Committed: https://crrev.com/9d0774bc242a8126f10c9be7922549336162ed88 > Cr-Commit-Position: refs/heads/master@{#434901} TBR=dgozman@chromium.org,allada@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Committed: https://crrev.com/6c2f9ee53faefc6bfd70834df9cfb794412eb425 Cr-Commit-Position: refs/heads/master@{#436770}

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
alph
Created Revert of [Devtools] Moved flatten children to children nodes instead of datagrid
4 years ago (2016-12-06 19:10:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554753004/1
4 years ago (2016-12-06 19:12:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 23:21:36 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-06 23:23:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c2f9ee53faefc6bfd70834df9cfb794412eb425
Cr-Commit-Position: refs/heads/master@{#436770}

Powered by Google App Engine
This is Rietveld 408576698