arc: Fix double provisioning failure reporting.

chrome/browser/chromeos/arc/arc_session_manager.cc

Index: chrome/browser/chromeos/arc/arc_session_manager.cc
diff --git a/chrome/browser/chromeos/arc/arc_session_manager.cc b/chrome/browser/chromeos/arc/arc_session_manager.cc
index 31595541115c22fa6f4ec32dd325f565805f6fdf..b0ae7c8fc40d4241c5aecf8a9be9d39ff6cb34c5 100644
--- a/chrome/browser/chromeos/arc/arc_session_manager.cc
+++ b/chrome/browser/chromeos/arc/arc_session_manager.cc
@@ -248,6 +248,15 @@ void ArcSessionManager::OnProvisioningFinished(ProvisioningResult result) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   DCHECK_EQ(state_, State::ACTIVE);

[Luis Héctor Chávez, 2016/12/06 17:50:45]

Move this after L258, because the state won't be State::ACTIVE the next time
this is called.

And speaking of that, can you add a small unit test that exercises this code
path?

[khmel, 2016/12/06 18:13:35]

This code is dropped in next CL https://codereview.chromium.org/2541173002/. 
Anyway moved it here.

 
+  if (result != ProvisioningResult::SUCCESS) {
+    if (provisioning_error_reported_) {
+      LOG(WARNING) << " Provisioning error was already reported. Ignoring "
+                   << " additional error " << static_cast<int>(result) << ".";
+      return;
+    }
+    provisioning_error_reported_ = true;
+  }
+
   if (result == ProvisioningResult::CHROME_SERVER_COMMUNICATION_ERROR) {
     if (IsArcKioskMode()) {
       VLOG(1) << "Robot account auth code fetching error";
@@ -591,6 +600,7 @@ void ArcSessionManager::StopAndEnableArc() {
 
 void ArcSessionManager::StartArc() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+  provisioning_error_reported_ = false;
   arc_bridge_service()->RequestStart();
   SetState(State::ACTIVE);
 }