Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 255473005: Cast: improve AV sync in sender application (Closed)

Created:
6 years, 8 months ago by Alpha Left Google
Modified:
6 years, 8 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Visibility:
Public.

Description

Cast: improve AV sync in sender application This change is to improve AV sync for transcoding. The algorithm is now changed to schedule for trancoding every 10ms. And then trasncoding audio into 10 ms blocks and send to the network. Video is then transcoded according to the audio timeline. I have also added looping support. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266125

Patch Set 1 #

Patch Set 2 : merged #

Patch Set 3 : nits #

Total comments: 3

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -75 lines) Patch
M media/cast/test/sender.cc View 1 2 3 15 chunks +158 lines, -75 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alpha Left Google
6 years, 8 months ago (2014-04-24 06:01:44 UTC) #1
hubbe
LGTM + nits https://codereview.chromium.org/255473005/diff/40001/media/cast/test/sender.cc File media/cast/test/sender.cc (right): https://codereview.chromium.org/255473005/diff/40001/media/cast/test/sender.cc#newcode415 media/cast/test/sender.cc:415: // playback rate is 1.0. Odd ...
6 years, 8 months ago (2014-04-24 22:32:51 UTC) #2
Alpha Left Google
Fixed all comments.
6 years, 8 months ago (2014-04-25 00:54:15 UTC) #3
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 8 months ago (2014-04-25 00:54:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/255473005/50001
6 years, 8 months ago (2014-04-25 00:58:11 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 03:44:32 UTC) #6
Message was sent while issue was closed.
Change committed as 266125

Powered by Google App Engine
This is Rietveld 408576698