docserver: Adds "API scheduled for Chrome version..." text to dev and beta APIs

chrome/common/extensions/docs/server2/availability_finder.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import Mapping
 import posixpath
 
 from api_schema_graph import APISchemaGraph
 from branch_utility import BranchUtility
 from extensions_paths import API_PATHS, JSON_TEMPLATES
@@ skipping 190 matching lines @@
     determined to be 'stable' at the given version.
     '''
     if channel_info.channel == 'stable':
       return self._CheckStableAvailability(api_name,
                                            file_system,
                                            channel_info.version)
     return self._CheckChannelAvailability(api_name,
                                           file_system,
                                           channel_info)
 
+  def _FindScheduled(self, api_name):
+    '''Determines the earliest version of Chrome where the API is stable.
+    Unlike the code in GetApiAvailability, this checks if the API is stable
+    even when Chrome is in dev or beta, which shows that the API is scheduled
+    to be stable in that verison of Chrome.
+    '''
+    def check_scheduled(file_system, channel_info):
+      return self._CheckStableAvailability(api_name,

[jshumway, 2014/04/25 21:34:43]

When arguments go past the end of the line but aren't that long by themselves,
use the following style:

```
return really_long_function_name(
    short_arg, short_arg, short_arg, short_arg)
```

so there isn't a big column of code on the right side of the file and it save
vertical space.

[danielj41, 2014/04/25 22:24:49]

Done.

+                                           file_system,
+                                           channel_info.version)
+    stable_availability = self._file_system_iterator.Descending(
+        self._branch_utility.GetChannelInfo('dev'),
+        check_scheduled)

[jshumway, 2014/04/25 21:34:43]

These two arguments can be on the same line under
`file_system_iterator.Descending(`

[danielj41, 2014/04/25 22:24:49]

Done.

+    if stable_availability:
+      return stable_availability.version
+    else:
+      return None

[jshumway, 2014/04/25 21:34:43]

The above if else can be

return stable_availability.version if stable_availability else None

[danielj41, 2014/04/25 22:24:49]

Done.

+
   def GetApiAvailability(self, api_name):
     '''Performs a search for an API's top-level availability by using a
     HostFileSystemIterator instance to traverse multiple version of the
     SVN filesystem.
     '''
     availability = self._top_level_object_store.Get(api_name).Get()
     if availability is not None:
       return availability
 
     # Check for predetermined availability and cache this information if found.
     availability = self._GetPredeterminedAvailability(api_name)
     if availability is not None:
       self._top_level_object_store.Set(api_name, availability)
       return availability
 
     def check_api_availability(file_system, channel_info):
       return self._CheckApiAvailability(api_name, file_system, channel_info)
 
     availability = self._file_system_iterator.Descending(
         self._branch_utility.GetChannelInfo('dev'),
         check_api_availability)
     if availability is None:
       # The API wasn't available on 'dev', so it must be a 'trunk'-only API.
       availability = self._branch_utility.GetChannelInfo('trunk')
+
+    # If the API is not stable, check if it is stable in the dev or beta
+    # versions of Chrome. This means that the API is scheduled to be stable.
+    if availability.channel != 'stable':
+      availability.scheduled = self._FindScheduled(api_name)
+
     self._top_level_object_store.Set(api_name, availability)
     return availability
 
   def GetApiNodeAvailability(self, api_name):
     '''Returns an APISchemaGraph annotated with each node's availability (the
     ChannelInfo at the oldest channel it's available in).
     '''
     availability_graph = self._node_level_object_store.Get(api_name).Get()
     if availability_graph is not None:
       return availability_graph
@@ skipping 37 matching lines @@
 
       # Continue looping until there are no longer differences between this
       # version and trunk.
       return version_stat != trunk_stat
 
     self._file_system_iterator.Ascending(self.GetApiAvailability(api_name),
                                          update_availability_graph)
 
     self._node_level_object_store.Set(api_name, availability_graph)
     return availability_graph