docserver: Adds "API scheduled for Chrome version..." text to dev and beta APIs

chrome/common/extensions/docs/server2/api_data_source_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import os
 import sys
 import unittest
 
@@ skipping 24 matching lines @@
     if type_['name'] == name:
       return type_
 
 
 class _FakeAvailabilityFinder(object):
 
   def GetApiAvailability(self, version):
     return ChannelInfo('stable', '396', 5)
 
 
+class _FakeScheduledAvailabilityFinder(object):
+
+  def GetApiAvailability(self, version):
+    return ChannelInfo('dev', '1500', 28, 28)
+
+
 class _FakeTemplateCache(object):
 
   def GetFromFile(self, key):
     return Future(value='handlebar %s' % key)
 
 
 class APIDataSourceTest(unittest.TestCase):
 
   def setUp(self):
     self._base_path = Server2Path('test_data', 'test_json')
@@ skipping 80 matching lines @@
     expected_list = [
       { 'title': 'Description',
         'content': [
           { 'text': 'a test api' }
         ]
       },
       { 'title': 'Availability',
         'content': [
           { 'partial': 'handlebar chrome/common/extensions/docs/' +
                        'templates/private/intro_tables/stable_message.html',
-            'version': 5
+            'version': 5,
+            'scheduled': None
           }
         ]
       },
+      { 'title': 'Permissions',
+        'content': [
+          { 'class': 'override',
+            'text': '"tester"'
+          },
+          { 'text': 'is an API for testing things.' }
+        ]
+      },
+      { 'title': 'Manifest',
+        'content': [
+          { 'class': 'code',
+            'text': '"tester": {...}'
+          }
+        ]
+      },
+      { 'title': 'Learn More',
+        'content': [
+          { 'link': 'https://tester.test.com/welcome.html',
+            'text': 'Welcome!'
+          }
+        ]
+      }
+    ]
+    self.assertEquals(model._GetIntroTableList(), expected_list)
+
+    model = _JSCModel(self._api_models.GetModel('tester').Get(),
+                      _FakeScheduledAvailabilityFinder(),
+                      self._json_cache,
+                      _FakeTemplateCache(),
+                      self._features_bundle,
+                      None)
+    expected_list = [

[jshumway, 2014/04/25 21:34:43]

Since only the second item in the list has changed, I would add

```
expected_list[1] = {
  'title': 'Availability',
  'content': [
    {
      'partial': ...,
      'version': 28,
      'scheduled': 28'
    }
  ]
}
```

instead of copying the entire definition.

Maybe add a small comment that you are mutating the expected to output to test
the scheduled feature.

[danielj41, 2014/04/25 22:24:49]

Done.

+      { 'title': 'Description',
+        'content': [
+          { 'text': 'a test api' }
+        ]
+      },
+      { 'title': 'Availability',
+        'content': [
+          { 'partial': 'handlebar chrome/common/extensions/docs/' +
+                       'templates/private/intro_tables/dev_message.html',
+            'version': 28,
+            'scheduled': 28
+          }
+        ]
+      },
       { 'title': 'Permissions',
         'content': [
           { 'class': 'override',
             'text': '"tester"'
           },
           { 'text': 'is an API for testing things.' }
         ]
       },
       { 'title': 'Manifest',
         'content': [
@@ skipping 54 matching lines @@
     # Check that the second event has addListener defined.
     self.assertEquals('noRules', dict_['events'][1]['name'])
     self.assertEquals('add_rules_tester', dict_['name'])
     self.assertEquals('noRules', dict_['events'][1]['name'])
     self.assertEquals('callback',
                       dict_['events'][0]['byName']['addListener'][
                           'parameters'][0]['name'])
 
 if __name__ == '__main__':
   unittest.main()