Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 255473002: device/bluetooth/OWNERS: Add set noparent. (Closed)

Created:
6 years, 8 months ago by armansito
Modified:
5 years, 4 months ago
Reviewers:
keybuk, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

device/bluetooth/OWNERS: Add set noparent. BUG=none R=keybuk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M device/bluetooth/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
armansito
6 years, 8 months ago (2014-04-23 23:44:22 UTC) #1
keybuk
lgtm
6 years, 8 months ago (2014-04-24 00:03:25 UTC) #2
armansito
Committed patchset #1 manually as r265784 (presubmit successful).
6 years, 8 months ago (2014-04-24 00:11:59 UTC) #3
Nico
owner files should generally not have noparent. why is this needed?
5 years, 5 months ago (2015-07-26 03:19:22 UTC) #5
AzoozAlmalki84
On 2015/07/26 03:19:22, Nico (vacation Mon Jul 27) wrote: > owner files should generally not ...
5 years, 5 months ago (2015-07-26 07:48:31 UTC) #6
Nico
On 2015/07/26 03:19:22, Nico wrote: > owner files should generally not have noparent. why is ...
5 years, 4 months ago (2015-07-28 19:59:26 UTC) #7
armansito
On 2015/07/28 19:59:26, Nico wrote: > On 2015/07/26 03:19:22, Nico wrote: > > owner files ...
5 years, 4 months ago (2015-07-29 16:19:24 UTC) #8
Nico
On 2015/07/29 16:19:24, armansito wrote: > On 2015/07/28 19:59:26, Nico wrote: > > On 2015/07/26 ...
5 years, 4 months ago (2015-07-29 16:21:44 UTC) #9
Nico
5 years, 4 months ago (2015-07-29 16:22:53 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1267513002/ by thakis@chromium.org.

The reason for reverting is: `set noparent` is generally an anti-pattern; if
it's necessary there are usually bigger issues that need to be fixed. Sounds
like that has happened for device/ and people are fine without noparent here, so
reverting this..

Powered by Google App Engine
This is Rietveld 408576698