Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: net/http2/decoder/payload_decoders/settings_payload_decoder_test.cc

Issue 2554683003: Revert of Add new HTTP/2 and HPACK decoder in net/http2/. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http2/decoder/payload_decoders/settings_payload_decoder_test.cc
diff --git a/net/http2/decoder/payload_decoders/settings_payload_decoder_test.cc b/net/http2/decoder/payload_decoders/settings_payload_decoder_test.cc
deleted file mode 100644
index 7a53797548428372668b85ad0f7ff0897da59628..0000000000000000000000000000000000000000
--- a/net/http2/decoder/payload_decoders/settings_payload_decoder_test.cc
+++ /dev/null
@@ -1,176 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "net/http2/decoder/payload_decoders/settings_payload_decoder.h"
-
-#include <stddef.h>
-
-#include <vector>
-
-#include "base/bind.h"
-#include "base/logging.h"
-#include "net/http2/decoder/frame_parts.h"
-#include "net/http2/decoder/frame_parts_collector.h"
-#include "net/http2/decoder/http2_frame_decoder_listener.h"
-#include "net/http2/decoder/payload_decoders/payload_decoder_base_test_util.h"
-#include "net/http2/http2_constants.h"
-#include "net/http2/http2_constants_test_util.h"
-#include "net/http2/http2_structures_test_util.h"
-#include "net/http2/tools/http2_frame_builder.h"
-#include "net/http2/tools/http2_random.h"
-#include "net/http2/tools/random_decoder_test.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace net {
-namespace test {
-
-class SettingsPayloadDecoderPeer {
- public:
- static constexpr Http2FrameType FrameType() {
- return Http2FrameType::SETTINGS;
- }
-
- // Returns the mask of flags that affect the decoding of the payload (i.e.
- // flags that that indicate the presence of certain fields or padding).
- static constexpr uint8_t FlagsAffectingPayloadDecoding() {
- return Http2FrameFlag::FLAG_ACK;
- }
-
- static void Randomize(SettingsPayloadDecoder* p, RandomBase* rng) {
- VLOG(1) << "SettingsPayloadDecoderPeer::Randomize";
- test::Randomize(&p->setting_fields_, rng);
- }
-};
-
-namespace {
-
-struct Listener : public FramePartsCollector {
- void OnSettingsStart(const Http2FrameHeader& header) override {
- VLOG(1) << "OnSettingsStart: " << header;
- EXPECT_EQ(Http2FrameType::SETTINGS, header.type) << header;
- EXPECT_EQ(Http2FrameFlag(), header.flags) << header;
- StartFrame(header)->OnSettingsStart(header);
- }
-
- void OnSetting(const Http2SettingFields& setting_fields) override {
- VLOG(1) << "Http2SettingFields: setting_fields=" << setting_fields;
- CurrentFrame()->OnSetting(setting_fields);
- }
-
- void OnSettingsEnd() override {
- VLOG(1) << "OnSettingsEnd";
- EndFrame()->OnSettingsEnd();
- }
-
- void OnSettingsAck(const Http2FrameHeader& header) override {
- VLOG(1) << "OnSettingsAck: " << header;
- StartAndEndFrame(header)->OnSettingsAck(header);
- }
-
- void OnFrameSizeError(const Http2FrameHeader& header) override {
- VLOG(1) << "OnFrameSizeError: " << header;
- FrameError(header)->OnFrameSizeError(header);
- }
-};
-
-class SettingsPayloadDecoderTest
- : public AbstractPayloadDecoderTest<SettingsPayloadDecoder,
- SettingsPayloadDecoderPeer,
- Listener> {
- public:
- static bool ApproveSizeForSettingsWrongSize(size_t size) {
- // Should get an error if size is not an integral multiple of the size
- // of one setting.
- return 0 != (size % Http2SettingFields::EncodedSize());
- }
-
- static bool ApproveSizeForSettingsAkcWrongSize(size_t size) {
- return size != 0;
- }
-
- protected:
- Http2SettingFields RandSettingsFields() {
- Http2SettingFields fields;
- test::Randomize(&fields, RandomPtr());
- return fields;
- }
-};
-
-// Confirm we get an error if the SETTINGS payload is not the correct size
-// to hold exactly zero or more whole Http2SettingFields.
-TEST_F(SettingsPayloadDecoderTest, SettingsWrongSize) {
- Http2FrameBuilder fb;
- fb.Append(RandSettingsFields());
- fb.Append(RandSettingsFields());
- fb.Append(RandSettingsFields());
- EXPECT_TRUE(VerifyDetectsFrameSizeError(
- 0, fb.buffer(),
- base::Bind(
- &SettingsPayloadDecoderTest::ApproveSizeForSettingsWrongSize)));
-}
-
-// Confirm we get an error if the SETTINGS ACK payload is not empty.
-TEST_F(SettingsPayloadDecoderTest, SettingsAkcWrongSize) {
- Http2FrameBuilder fb;
- fb.Append(RandSettingsFields());
- fb.Append(RandSettingsFields());
- fb.Append(RandSettingsFields());
- EXPECT_TRUE(VerifyDetectsFrameSizeError(
- Http2FrameFlag::FLAG_ACK, fb.buffer(),
- base::Bind(
- &SettingsPayloadDecoderTest::ApproveSizeForSettingsAkcWrongSize)));
-}
-
-// SETTINGS must have stream_id==0, but the payload decoder doesn't check that.
-TEST_F(SettingsPayloadDecoderTest, SettingsAck) {
- for (int stream_id = 0; stream_id < 3; ++stream_id) {
- Http2FrameHeader header(0, Http2FrameType::SETTINGS,
- RandFlags() | Http2FrameFlag::FLAG_ACK, stream_id);
- set_frame_header(header);
- FrameParts expected(header);
- EXPECT_TRUE(DecodePayloadAndValidateSeveralWays("", expected));
- }
-}
-
-// Try several values of each known SETTINGS parameter.
-TEST_F(SettingsPayloadDecoderTest, OneRealSetting) {
- std::vector<uint32_t> values = {0, 1, 0xffffffff, Random().Rand32()};
- for (auto param : AllHttp2SettingsParameters()) {
- for (uint32_t value : values) {
- Http2SettingFields fields(param, value);
- Http2FrameBuilder fb;
- fb.Append(fields);
- Http2FrameHeader header(fb.size(), Http2FrameType::SETTINGS, RandFlags(),
- RandStreamId());
- set_frame_header(header);
- FrameParts expected(header);
- expected.settings.push_back(fields);
- EXPECT_TRUE(DecodePayloadAndValidateSeveralWays(fb.buffer(), expected));
- }
- }
-}
-
-// Decode a SETTINGS frame with lots of fields.
-TEST_F(SettingsPayloadDecoderTest, ManySettings) {
- const uint32_t num_settings = 100;
- const uint32_t size = Http2SettingFields::EncodedSize() * num_settings;
- Http2FrameHeader header(size, Http2FrameType::SETTINGS,
- RandFlags(), // & ~Http2FrameFlag::FLAG_ACK,
- RandStreamId());
- set_frame_header(header);
- FrameParts expected(header);
- Http2FrameBuilder fb;
- for (size_t n = 0; n < num_settings; ++n) {
- Http2SettingFields fields(static_cast<Http2SettingsParameter>(n),
- Random().Rand32());
- fb.Append(fields);
- expected.settings.push_back(fields);
- }
- ASSERT_EQ(size, fb.size());
- EXPECT_TRUE(DecodePayloadAndValidateSeveralWays(fb.buffer(), expected));
-}
-
-} // namespace
-} // namespace test
-} // namespace net

Powered by Google App Engine
This is Rietveld 408576698