Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: net/http2/decoder/payload_decoders/goaway_payload_decoder_test.cc

Issue 2554683003: Revert of Add new HTTP/2 and HPACK decoder in net/http2/. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http2/decoder/payload_decoders/goaway_payload_decoder_test.cc
diff --git a/net/http2/decoder/payload_decoders/goaway_payload_decoder_test.cc b/net/http2/decoder/payload_decoders/goaway_payload_decoder_test.cc
deleted file mode 100644
index 248ac0d19e2a4bf5806df62ca18caa43b9d77f67..0000000000000000000000000000000000000000
--- a/net/http2/decoder/payload_decoders/goaway_payload_decoder_test.cc
+++ /dev/null
@@ -1,122 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "net/http2/decoder/payload_decoders/goaway_payload_decoder.h"
-
-#include <stddef.h>
-
-#include <string>
-
-#include "base/bind.h"
-#include "base/logging.h"
-#include "net/http2/decoder/frame_parts.h"
-#include "net/http2/decoder/frame_parts_collector.h"
-#include "net/http2/decoder/http2_frame_decoder_listener.h"
-#include "net/http2/decoder/payload_decoders/payload_decoder_base_test_util.h"
-#include "net/http2/http2_constants.h"
-#include "net/http2/http2_structures_test_util.h"
-#include "net/http2/tools/http2_frame_builder.h"
-#include "net/http2/tools/http2_random.h"
-#include "net/http2/tools/random_decoder_test.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using std::string;
-
-namespace net {
-namespace test {
-
-class GoAwayPayloadDecoderPeer {
- public:
- static constexpr Http2FrameType FrameType() { return Http2FrameType::GOAWAY; }
-
- // Returns the mask of flags that affect the decoding of the payload (i.e.
- // flags that that indicate the presence of certain fields or padding).
- static constexpr uint8_t FlagsAffectingPayloadDecoding() { return 0; }
-
- static void Randomize(GoAwayPayloadDecoder* p, RandomBase* rng) {
- CorruptEnum(&p->payload_state_, rng);
- test::Randomize(&p->goaway_fields_, rng);
- VLOG(1) << "GoAwayPayloadDecoderPeer::Randomize goaway_fields: "
- << p->goaway_fields_;
- }
-};
-
-namespace {
-
-struct Listener : public FramePartsCollector {
- void OnGoAwayStart(const Http2FrameHeader& header,
- const Http2GoAwayFields& goaway) override {
- VLOG(1) << "OnGoAwayStart header: " << header << "; goaway: " << goaway;
- StartFrame(header)->OnGoAwayStart(header, goaway);
- }
-
- void OnGoAwayOpaqueData(const char* data, size_t len) override {
- VLOG(1) << "OnGoAwayOpaqueData: len=" << len;
- CurrentFrame()->OnGoAwayOpaqueData(data, len);
- }
-
- void OnGoAwayEnd() override {
- VLOG(1) << "OnGoAwayEnd";
- EndFrame()->OnGoAwayEnd();
- }
-
- void OnFrameSizeError(const Http2FrameHeader& header) override {
- VLOG(1) << "OnFrameSizeError: " << header;
- FrameError(header)->OnFrameSizeError(header);
- }
-};
-
-class GoAwayPayloadDecoderTest
- : public AbstractPayloadDecoderTest<GoAwayPayloadDecoder,
- GoAwayPayloadDecoderPeer,
- Listener> {
- public:
- static bool ApproveSizeForTruncated(size_t size) {
- return size != Http2GoAwayFields::EncodedSize();
- }
-};
-
-// Confirm we get an error if the payload is not long enough to hold
-// Http2GoAwayFields.
-TEST_F(GoAwayPayloadDecoderTest, Truncated) {
- Http2FrameBuilder fb;
- fb.Append(Http2GoAwayFields(123, Http2ErrorCode::ENHANCE_YOUR_CALM));
- EXPECT_TRUE(VerifyDetectsFrameSizeError(
- 0, fb.buffer(),
- base::Bind(&GoAwayPayloadDecoderTest::ApproveSizeForTruncated)));
-}
-
-class GoAwayOpaqueDataLengthTests
- : public GoAwayPayloadDecoderTest,
- public ::testing::WithParamInterface<uint32_t> {
- protected:
- GoAwayOpaqueDataLengthTests() : length_(GetParam()) {
- VLOG(1) << "################ length_=" << length_ << " ################";
- }
-
- const uint32_t length_;
-};
-
-INSTANTIATE_TEST_CASE_P(VariousLengths,
- GoAwayOpaqueDataLengthTests,
- ::testing::Values(0, 1, 2, 3, 4, 5, 6));
-
-TEST_P(GoAwayOpaqueDataLengthTests, ValidLength) {
- Http2GoAwayFields goaway;
- Randomize(&goaway, RandomPtr());
- string opaque_data = Random().RandString(length_);
- Http2FrameBuilder fb;
- fb.Append(goaway);
- fb.Append(opaque_data);
- Http2FrameHeader header(fb.size(), Http2FrameType::GOAWAY, RandFlags(),
- RandStreamId());
- set_frame_header(header);
- FrameParts expected(header, opaque_data);
- expected.opt_goaway = goaway;
- ASSERT_TRUE(DecodePayloadAndValidateSeveralWays(fb.buffer(), expected));
-}
-
-} // namespace
-} // namespace test
-} // namespace net

Powered by Google App Engine
This is Rietveld 408576698