Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2554673002: Renamed members of EPointerEvents to match CSSValueKeywords.in (Closed)

Created:
4 years ago by napper
Modified:
4 years ago
Reviewers:
sashab, dcheng
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dcheng, dglazkov+blink, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed members of EPointerEvents to match CSSValueKeywords.in. Renamed members of EPointerEvents to match the keywords to the values in CSSValueKeywords.in. This is a rename only - there are no logic changes. This is pre-work to move EPointerEvents to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/2e622f7aad97866963d8784950fa8a72555519d5 Cr-Commit-Position: refs/heads/master@{#436503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -67 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/PointerEventsHitRules.cpp View 1 chunk +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
napper
4 years ago (2016-12-06 00:05:05 UTC) #3
sashab
Nit - full stop at end of CL desc Other than that LGTM :D
4 years ago (2016-12-06 00:06:10 UTC) #4
napper
dcheng@ please OWNERS review web/WebRemoteFrameImpl.cpp. This is a rename only and contains no logic changes.
4 years ago (2016-12-06 00:27:46 UTC) #9
dcheng
rs lgtm
4 years ago (2016-12-06 00:35:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554673002/1
4 years ago (2016-12-06 01:40:30 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 03:00:02 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-06 03:01:32 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e622f7aad97866963d8784950fa8a72555519d5
Cr-Commit-Position: refs/heads/master@{#436503}

Powered by Google App Engine
This is Rietveld 408576698