Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25546003: Revert 226264 "Be able to build cast_unittest and related target..." (Closed)

Created:
7 years, 2 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 2 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 226264 "Be able to build cast_unittest and related target..." This patch was causing the Mac bot build to fail. > Be able to build cast_unittest and related targets in Chrome tree > > Adding cast.gyp to build/all.gyp. Also a bunch of chromium style errors. > > Review URL: https://codereview.chromium.org/24586003 TBR=hclam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -321 lines) Patch
M trunk/src/build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_decoder.h View 3 chunks +5 lines, -7 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_decoder.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_receiver.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_receiver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_encoder.h View 3 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_encoder.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/audio_sender/audio_sender.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/cast.gyp View 2 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/media/cast/cast_config.h View 2 chunks +0 lines, -5 lines 0 comments Download
MM trunk/src/media/cast/cast_config.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/media/cast/cast_receiver.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/media/cast/cast_receiver.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/cast_sender.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/media/cast/cast_sender.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/cast_sender_impl.h View 1 chunk +7 lines, -2 lines 0 comments Download
M trunk/src/media/cast/cast_sender_impl.cc View 4 chunks +2 lines, -18 lines 0 comments Download
M trunk/src/media/cast/cast_thread.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/media/cast/cast_thread.cc View 3 chunks +1 line, -7 lines 0 comments Download
M trunk/src/media/cast/congestion_control/congestion_control.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/congestion_control/congestion_control.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/media/cast/framer/cast_message_builder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/framer/frame_buffer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/framer/framer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/pacing/mock_paced_packet_sender.h View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/media/cast/pacing/mock_paced_packet_sender.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/media/cast/pacing/mock_packet_sender.h View 1 chunk +0 lines, -2 lines 0 comments Download
D trunk/src/media/cast/pacing/mock_packet_sender.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/media/cast/pacing/paced_sender.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/media/cast/pacing/paced_sender.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/rtcp/mock_rtcp_receiver_feedback.h View 2 chunks +0 lines, -6 lines 0 comments Download
D trunk/src/media/cast/rtcp/mock_rtcp_receiver_feedback.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M trunk/src/media/cast/rtcp/mock_rtcp_sender_feedback.h View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/media/cast/rtcp/mock_rtcp_sender_feedback.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_receiver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_sender.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_sender_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/media/cast/rtcp/test_rtcp_packet_builder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/media/cast/rtcp/test_rtcp_packet_builder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/media/cast/rtp_common/mock_rtp_payload_feedback.h View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/media/cast/rtp_common/mock_rtp_payload_feedback.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/media/cast/rtp_receiver/receiver_stats_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/rtp_receiver/rtp_parser/rtp_parser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/media/cast/rtp_receiver/rtp_parser/rtp_parser_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/rtp_sender/rtp_packetizer/rtp_packetizer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/media/cast/rtp_sender/rtp_packetizer/rtp_packetizer_config.h View 1 chunk +9 lines, -1 line 0 comments Download
D trunk/src/media/cast/rtp_sender/rtp_packetizer/rtp_packetizer_config.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M trunk/src/media/cast/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_receiver/video_decoder.h View 2 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/media/cast/video_receiver/video_decoder_unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/src/media/cast/video_receiver/video_receiver.cc View 2 chunks +5 lines, -1 line 0 comments Download
M trunk/src/media/cast/video_receiver/video_receiver_unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/src/media/cast/video_sender/codecs/vp8/vp8_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_sender/mock_video_encoder_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/media/cast/video_sender/mock_video_encoder_controller.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_encoder.h View 3 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_encoder.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_encoder_unittest.cc View 2 chunks +1 line, -6 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_sender/video_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
acolwell GONE FROM CHROMIUM
7 years, 2 months ago (2013-10-01 18:35:24 UTC) #1
acolwell GONE FROM CHROMIUM
7 years, 2 months ago (2013-10-01 18:35:49 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r226267.

Powered by Google App Engine
This is Rietveld 408576698