Get rid of ImageTransportFactory::GetSurfaceManager

Get rid of ImageTransportFactory::GetSurfaceManager

SurfaceManager was accessible through both ImageTransportFactory AND
ContextFactory. This CL removes the accessor on ImageTransportFactory
which is redundant.

BUG=657959
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/f3812452a1a442002c99a61737ebfd06a963b9dd
Cr-Commit-Position: refs/heads/master@{#436830}

[Fady Samuel, 2016-12-05 18:40:39]

Description was changed from

==========
Get rid of ImageTransportFactory::GetSurfaceManager

BUG=
==========

to

==========
Get rid of ImageTransportFactory::GetSurfaceManager

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Fady Samuel, 2016-12-05 18:41:49]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 18:42:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 19:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 19:15:19]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2016-12-06 22:02:53]

Description was changed from

==========
Get rid of ImageTransportFactory::GetSurfaceManager

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Get rid of ImageTransportFactory::GetSurfaceManager

SurfaceManager was accessible through both ImageTransportFactory AND
ContextFactory. This CL removes the accessor on ImageTransportFactory 
which is redundant.

BUG=657959
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Fady Samuel, 2016-12-06 22:03:00]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-12-06 22:03:13]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[Fady Samuel, 2016-12-06 22:03:13]

PTAL Antoine! Thanks.

[commit-bot: I haz the power, 2016-12-06 22:03:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-12-06 23:47:57]

LGTM, but I think eventually we'll also want to remove the one from
ContextFactory

[commit-bot: I haz the power, 2016-12-07 00:53:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:53:16]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-12-07 01:47:27]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:47:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 01:53:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481075247349970,
"parent_rev": "3be756853503fdc8c3fd9afe64281232b7d386b9", "commit_rev":
"102836a23f1eae1d0e7e7ea7b4b73db47ce77572"}

[commit-bot: I haz the power, 2016-12-07 01:54:17]

Description was changed from

==========
Get rid of ImageTransportFactory::GetSurfaceManager

SurfaceManager was accessible through both ImageTransportFactory AND
ContextFactory. This CL removes the accessor on ImageTransportFactory 
which is redundant.

BUG=657959
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Get rid of ImageTransportFactory::GetSurfaceManager

SurfaceManager was accessible through both ImageTransportFactory AND
ContextFactory. This CL removes the accessor on ImageTransportFactory 
which is redundant.

BUG=657959
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-12-07 01:54:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 01:55:50]

Description was changed from

==========
Get rid of ImageTransportFactory::GetSurfaceManager

SurfaceManager was accessible through both ImageTransportFactory AND
ContextFactory. This CL removes the accessor on ImageTransportFactory 
which is redundant.

BUG=657959
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Get rid of ImageTransportFactory::GetSurfaceManager

SurfaceManager was accessible through both ImageTransportFactory AND
ContextFactory. This CL removes the accessor on ImageTransportFactory
which is redundant.

BUG=657959
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/f3812452a1a442002c99a61737ebfd06a963b9dd
Cr-Commit-Position: refs/heads/master@{#436830}
==========

[commit-bot: I haz the power, 2016-12-07 01:55:52]

Patchset 2 (id:??) landed as
https://crrev.com/f3812452a1a442002c99a61737ebfd06a963b9dd
Cr-Commit-Position: refs/heads/master@{#436830}

[Fady Samuel, 2016-12-07 02:59:22]

On 2016/12/06 23:47:57, piman wrote:
> LGTM, but I think eventually we'll also want to remove the one from
> ContextFactory

Yes, we do. I'm currently doing a more in depth audit of what needs to be
refactored. I noticed this and so I thought I'd pick off some low hanging fruit.