Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2554573010: DevTools: fix presubmit hooks for windows (Closed)

Created:
4 years ago by chenwilliam
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix presubmit hooks for windows Note: For Windows, the presubmit hook works in cmd, however there's some issues in cygwin. BUG=670058 Committed: https://crrev.com/e2178ba06208ff83c690514dc762f72c9842a150 Cr-Commit-Position: refs/heads/master@{#437133}

Patch Set 1 #

Patch Set 2 : clean #

Patch Set 3 : nit #

Patch Set 4 : include utils.py in BUILD.gn isolate target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -45 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/compile_frontend.py View 3 chunks +3 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/install_node_deps.py View 4 chunks +6 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/lint_javascript.py View 3 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/utils.py View 1 2 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
chenwilliam
PTAL - it's still not quite working in cygwin but at least in normal cmd ...
4 years ago (2016-12-07 20:28:45 UTC) #2
dgozman
lgtm
4 years ago (2016-12-07 21:39:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554573010/40001
4 years ago (2016-12-07 21:54:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554573010/60001
4 years ago (2016-12-07 23:24:49 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-08 01:56:55 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-08 01:59:16 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e2178ba06208ff83c690514dc762f72c9842a150
Cr-Commit-Position: refs/heads/master@{#437133}

Powered by Google App Engine
This is Rietveld 408576698