[pdf] Reset defer_page_unload to original value.

[pdf] Reset defer_page_unload to original value.

In the PdfiumEngine::GetMostVisiblePage() we force the system to defer page
unloading because it can be called during a callback. That callback can be
triggered from a ::HandleEvent() call. Currently we will always reset the
defer_page_unload_ to false in ::GetMostVisiblePage().

This Cl updates the code to reset defer_page_unload_ to the value it contained
prior to the call to ::GetMostVisiblePage().

Committed: https://crrev.com/8e36ea8099dbbbc4ab3d87e598ba03cebc55a6b0
Cr-Commit-Position: refs/heads/master@{#436590}

[dsinclair, 2016-12-05 16:40:52]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 16:41:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-12-05 16:41:04]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-12-05 16:41:05]

PTAL.

[commit-bot: I haz the power, 2016-12-05 17:21:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 17:21:25]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-05 17:54:05]

https://codereview.chromium.org/2554563002/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/2554563002/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:2473: bool old_defer_page_unload =
defer_page_unload_;
base::AutoReset maybe?

[dsinclair, 2016-12-05 20:07:48]

https://codereview.chromium.org/2554563002/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/2554563002/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:2473: bool old_defer_page_unload =
defer_page_unload_;
On 2016/12/05 17:54:05, Tom Sepez wrote:
> base::AutoReset maybe?

Done.

[Tom Sepez, 2016-12-05 21:05:37]

lgtm

[dsinclair, 2016-12-06 13:49:22]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-12-06 13:49:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 14:33:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481032162935480,
"parent_rev": "cfe0c03172e631822e56150ad62855a13497c5cf", "commit_rev":
"11235da27a5c1b5d57f5c6c430983d188f06b870"}

[commit-bot: I haz the power, 2016-12-06 14:33:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-06 14:35:30]

Description was changed from

==========
[pdf] Reset defer_page_unload to original value.

In the PdfiumEngine::GetMostVisiblePage() we force the system to defer page
unloading because it can be called during a callback. That callback can be
triggered from a ::HandleEvent() call. Currently we will always reset the
defer_page_unload_ to false in ::GetMostVisiblePage().

This Cl updates the code to reset defer_page_unload_ to the value it contained
prior to the call to ::GetMostVisiblePage().
==========

to

==========
[pdf] Reset defer_page_unload to original value.

In the PdfiumEngine::GetMostVisiblePage() we force the system to defer page
unloading because it can be called during a callback. That callback can be
triggered from a ::HandleEvent() call. Currently we will always reset the
defer_page_unload_ to false in ::GetMostVisiblePage().

This Cl updates the code to reset defer_page_unload_ to the value it contained
prior to the call to ::GetMostVisiblePage().

Committed: https://crrev.com/8e36ea8099dbbbc4ab3d87e598ba03cebc55a6b0
Cr-Commit-Position: refs/heads/master@{#436590}
==========

[commit-bot: I haz the power, 2016-12-06 14:35:31]

Patchset 2 (id:??) landed as
https://crrev.com/8e36ea8099dbbbc4ab3d87e598ba03cebc55a6b0
Cr-Commit-Position: refs/heads/master@{#436590}