Source/core/page/DOMSelection.cpp - Issue 255453003: Let Selection.deleteFromDocument not delete a character when the selection is a caret.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DOMSelection.cpp

Issue 255453003: Let Selection.deleteFromDocument not delete a character when the selection is a caret. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/selection/deleteFromDocument-undo-crash-expected.txt ('K') | « LayoutTests/editing/selection/deleteFromDocument-undo-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/DOMSelection.cpp

diff --git a/Source/core/page/DOMSelection.cpp b/Source/core/page/DOMSelection.cpp

index 1765d5af0019a445fb79323891608bc2d91d4ff7..ebde68e61b0aabacef172ce9208df35978b90f7a 100644

--- a/Source/core/page/DOMSelection.cpp

+++ b/Source/core/page/DOMSelection.cpp

@@ -447,9 +447,6 @@ void DOMSelection::deleteFromDocument()

if (selection.isNone())

return;

- if (isCollapsed())

- selection.modify(FrameSelection::AlterationExtend, DirectionBackward, CharacterGranularity);

RefPtrWillBeRawPtr<Range> selectedRange = selection.selection().toNormalizedRange();

if (!selectedRange)

return;