[refactor] Use a lookup table rather than binary search for algorithm normalization.

[refactor] Use a lookup table rather than binary search for algorithm normalization.

Pros: Uses less space, is faster, and easier to extend with new properties.

Cons: Slightly more difficult to edit.

BUG=245025
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172557

[eroman, 2014-04-23 23:26:23]

https://codereview.chromium.org/255453002/diff/2/Source/modules/crypto/Normal...
File Source/modules/crypto/NormalizeAlgorithm.cpp (right):

https://codereview.chromium.org/255453002/diff/2/Source/modules/crypto/Normal...
Source/modules/crypto/NormalizeAlgorithm.cpp:82: struct AlgorithmInfo {
Rather than introduce another switch statement on algorithmId, I decided to
store all the per-algorithm information in a static map. This big chunk of code
is re-formatting "operationParamsMapping" to a fixed array.

Although it is a harder to read/edit than before it has the advantage of:
  * Faster lookup time
  * Smaller static data size

https://codereview.chromium.org/255453002/diff/2/Source/modules/crypto/Normal...
Source/modules/crypto/NormalizeAlgorithm.cpp:99: "AES-CBC",
The names were moved from algorithmIdToName().

[eroman, 2014-04-24 01:05:22]

Sorry, please hold off on this, there is an issue I need to address...

[eroman, 2014-04-24 01:19:59]

OK ready for review now.

(I removed the other changes and turned this into a strict refactor.)

[abarth-chromium, 2014-04-24 14:49:40]

LGTM but you've got a bunch of red bots...

[eroman, 2014-04-24 19:42:25]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-04-24 19:43:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/255453002/70001

[eroman, 2014-04-24 19:43:33]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2014-04-24 19:51:14]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-04-24 19:51:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/255453002/90001

[commit-bot: I haz the power, 2014-04-24 23:28:12]

Change committed as 172557