content/browser/renderer_host/render_widget_host_view_aura.h - Issue 2554513002: Change |EnsureCaretInRect| to |EnsureCaretNotInRect|.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 2554513002: Change |EnsureCaretInRect| to |EnsureCaretNotInRect|. (Closed)

Patch Set: update the added test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_aura.h

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h

index 667641d751b7d97a5e47c98b053dc63909395cfe..3fb3a3d1fcbaa155e2e740913f1ef7f0374de06d 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.h

+++ b/content/browser/renderer_host/render_widget_host_view_aura.h

@@ -220,7 +220,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAura

bool ChangeTextDirectionAndLayoutAlignment(

base::i18n::TextDirection direction) override;

void ExtendSelectionAndDelete(size_t before, size_t after) override;

- void EnsureCaretInRect(const gfx::Rect& rect) override;

+ void EnsureCaretNotInRect(const gfx::Rect& rect) override;

bool IsTextEditCommandEnabled(ui::TextEditCommand command) const override;

void SetTextEditCommandForNextKeyEvent(ui::TextEditCommand command) override;