Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: ui/base/ime/text_input_client.h

Issue 2554513002: Change |EnsureCaretInRect| to |EnsureCaretNotInRect|. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/dummy_text_input_client.cc ('k') | ui/keyboard/keyboard_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/text_input_client.h
diff --git a/ui/base/ime/text_input_client.h b/ui/base/ime/text_input_client.h
index 3d032b0500fd0a0f9e2dd1ad1afdb84a1832003d..d76c00a49a9681f9f2171a652549ef75eeeed778 100644
--- a/ui/base/ime/text_input_client.h
+++ b/ui/base/ime/text_input_client.h
@@ -162,13 +162,13 @@ class UI_BASE_IME_EXPORT TextInputClient {
// between browser and renderer.
virtual void ExtendSelectionAndDelete(size_t before, size_t after) = 0;
- // Ensure the caret is within |rect|. |rect| is in screen coordinates and
+ // Ensure the caret is not in |rect|. |rect| is in screen coordinates and
// may extend beyond the bounds of this TextInputClient.
// Note: On Windows, the returned value is supposed to be DIP (Density
// Independent Pixel).
// TODO(ime): Have a clear spec whether the returned value is DIP or not.
// http://crbug.com/360334
- virtual void EnsureCaretInRect(const gfx::Rect& rect) = 0;
+ virtual void EnsureCaretNotInRect(const gfx::Rect& rect) = 0;
// Returns true if |command| is currently allowed to be executed.
virtual bool IsTextEditCommandEnabled(TextEditCommand command) const = 0;
« no previous file with comments | « ui/base/ime/dummy_text_input_client.cc ('k') | ui/keyboard/keyboard_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698