Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: third_party/WebKit/Tools/Scripts/run-bindings-tests

Issue 2554503004: Add running unit tests to run-bindings-tests. (Closed)
Patch Set: Feedback addressed. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/run-bindings-tests
diff --git a/third_party/WebKit/Tools/Scripts/run-bindings-tests b/third_party/WebKit/Tools/Scripts/run-bindings-tests
index 6f4ab449292688ebd6f65b5811cec58206fa40e3..12f285bc59c4ca127b9e933d66da9c41b0da229b 100755
--- a/third_party/WebKit/Tools/Scripts/run-bindings-tests
+++ b/third_party/WebKit/Tools/Scripts/run-bindings-tests
@@ -25,6 +25,11 @@
import sys
+from webkitpy.common import webkit_finder
+webkit_finder.add_typ_dir_to_sys_path()
+
+import typ
+
from webkitpy.bindings.bindings_tests import run_bindings_tests
Dirk Pranke 2016/12/08 17:56:12 Nit: I think lines 29-31 actually should show up a
@@ -44,8 +49,15 @@ def main(argv):
reset_results = '--reset-results' in argv
verbose = '--verbose' in argv
- return run_bindings_tests(reset_results, verbose)
+ # First, run bindings unit tests.
+ return_code = typ.main(
+ top_level_dir=webkit_finder.get_bindings_scripts_dir(),
+ win_multiprocessing='spawn')
+ if return_code != 0:
+ return return_code
+ # Now run the bindings end-to-end tests.
+ return run_bindings_tests(reset_results, verbose)
Dirk Pranke 2016/12/08 17:56:12 Nit: put this line back in :).
if __name__ == '__main__':
sys.exit(main(sys.argv))
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/test-webkitpy » ('j') | third_party/WebKit/Tools/Scripts/test-webkitpy » ('J')

Powered by Google App Engine
This is Rietveld 408576698