Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2554453002: Remove handling for V8History from failed access callback. (Closed)

Created:
4 years ago by dcheng
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, Mike West
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove handling for V8History from failed access callback. BUG=none Committed: https://crrev.com/78ebd5687ac958d267821d1ca543150a807f8a9a Cr-Commit-Position: refs/heads/master@{#436314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
dcheng
I think this is a leftover from when history was accessible cross-origin?
4 years ago (2016-12-05 09:06:19 UTC) #4
haraken
LGTM
4 years ago (2016-12-05 09:27:13 UTC) #5
Yuki
lgtm
4 years ago (2016-12-05 09:50:59 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-12-05 15:25:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554453002/1
4 years ago (2016-12-05 16:20:52 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 16:27:17 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-05 16:29:00 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78ebd5687ac958d267821d1ca543150a807f8a9a
Cr-Commit-Position: refs/heads/master@{#436314}

Powered by Google App Engine
This is Rietveld 408576698