Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2554433003: Add onauxclick and onpointer* as content attribute (Closed)

Created:
4 years ago by Navid Zolghadr
Modified:
4 years ago
Reviewers:
bokan, mustaq
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, domenic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add onauxclick and onpointer* as content attribute onauxclick and onpointer* attributes were missing from the content attributes after those features were added. This CL adds those. BUG=670078 Committed: https://crrev.com/dcabe3a6d92c6410da0469c2fb02a6b0fd1fe939 Cr-Commit-Position: refs/heads/master@{#436689}

Patch Set 1 #

Patch Set 2 : Remove test failure expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
D third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/events/event-handler-onauxclick-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.in View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Navid Zolghadr
4 years ago (2016-12-05 20:42:37 UTC) #4
mustaq
lgtm
4 years ago (2016-12-05 21:16:48 UTC) #5
Navid Zolghadr
4 years ago (2016-12-05 21:18:08 UTC) #7
bokan
lgtm
4 years ago (2016-12-06 17:33:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554433003/20001
4 years ago (2016-12-06 17:34:32 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 19:39:53 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-06 19:43:28 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dcabe3a6d92c6410da0469c2fb02a6b0fd1fe939
Cr-Commit-Position: refs/heads/master@{#436689}

Powered by Google App Engine
This is Rietveld 408576698