Remove Profile dependency from TiclInvalidationService

chrome/browser/invalidation/ticl_invalidation_service_profile_settings_provider.h

Index: chrome/browser/invalidation/ticl_invalidation_service_profile_settings_provider.h
diff --git a/chrome/browser/invalidation/ticl_invalidation_service_profile_settings_provider.h b/chrome/browser/invalidation/ticl_invalidation_service_profile_settings_provider.h
new file mode 100644
index 0000000000000000000000000000000000000000..c5c0fc6acfe517d440a1ab708943999d3892c187
--- /dev/null
+++ b/chrome/browser/invalidation/ticl_invalidation_service_profile_settings_provider.h
@@ -0,0 +1,37 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_INVALIDATION_TICL_INVALIDATION_SERVICE_PROFILE_SETTINGS_PROVIDER_H_
+#define CHROME_BROWSER_INVALIDATION_TICL_INVALIDATION_SERVICE_PROFILE_SETTINGS_PROVIDER_H_
+
+#include "base/compiler_specific.h"
+#include "base/macros.h"
+#include "base/prefs/pref_change_registrar.h"
+#include "chrome/browser/invalidation/ticl_invalidation_service_settings_provider.h"
+
+class Profile;
+
+namespace invalidation {
+
+// A specialization of TiclInvalidationServiceSettingsProvider that reads
+// settings from user prefs.
+class TiclInvalidationServiceProfileSettingsProvider
+    : public TiclInvalidationServiceSettingsProvider {
+ public:
+  explicit TiclInvalidationServiceProfileSettingsProvider(Profile* profile);
+  virtual ~TiclInvalidationServiceProfileSettingsProvider();
+
+  // TiclInvalidationServiceSettingsProvider:
+  virtual bool UseGCMChannel() const OVERRIDE;
+
+ private:
+  PrefChangeRegistrar registrar_;
+  Profile* profile_;

[dcheng, 2014/04/24 18:26:54]

Nit: Profile* const.

[bartfab (slow), 2014/04/24 19:14:48]

This gets fed to gcm::GCMProfileService::GetGCMEnabledState(), which requires a
non-const pointer.

[dcheng, 2014/04/24 21:02:18]

T* const, not const T*. The former simply means that the pointer value is
immutable for the lifetime of this class, while the latter indicates that you
can't call non-const methods on it. A T* const can still be passed to a function
that takes a T*.

[bartfab (slow), 2014/04/25 08:51:27]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(TiclInvalidationServiceProfileSettingsProvider);
+};
+
+}  // namespace invalidation
+
+#endif  // CHROME_BROWSER_INVALIDATION_TICL_INVALIDATION_SERVICE_PROFILE_SETTINGS_PROVIDER_H_