Implement argument validation for chrome.cast.channel.{open,send}

chrome/browser/extensions/api/cast_channel/cast_channel_apitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "chrome/browser/extensions/api/cast_channel/cast_channel_api.h"
 #include "chrome/browser/extensions/api/cast_channel/cast_socket.h"
 #include "chrome/browser/extensions/extension_apitest.h"
+#include "chrome/browser/extensions/extension_function_test_utils.h"
 #include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/ui/browser.h"
 #include "chrome/common/extensions/api/cast_channel.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/common/switches.h"
 #include "net/base/capturing_net_log.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_errors.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gmock_mutant.h"
 
 namespace cast_channel =  extensions::api::cast_channel;
 using cast_channel::CastSocket;
 using cast_channel::ChannelError;
 using cast_channel::MessageInfo;
 using cast_channel::ReadyState;
+using extensions::Extension;
+
+namespace utils = extension_function_test_utils;
 
 using ::testing::_;
 using ::testing::A;
 using ::testing::DoAll;
 using ::testing::Invoke;
 using ::testing::InSequence;
 using ::testing::Return;
 
 namespace {
 
@@ skipping 216 matching lines @@
       .WillRepeatedly(Return(cast_channel::READY_STATE_CLOSED));
   EXPECT_CALL(*mock_cast_socket_, Close(_));
 
   EXPECT_TRUE(RunExtensionSubtest("cast_channel/api",
                                   "test_open_error.html"));
 
   ResultCatcher catcher;
   EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
+IN_PROC_BROWSER_TEST_F(CastChannelAPITest, TestOpenInvalidUrl) {
+  scoped_refptr<extensions::CastChannelOpenFunction> cast_channel_open_function(
+      new extensions::CastChannelOpenFunction);
+  scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension());
+  cast_channel_open_function->set_extension(empty_extension.get());
+
+  std::string error(utils::RunFunctionAndReturnError(
+      cast_channel_open_function.get(), "[\"blargh\"]", browser()));
+
+  EXPECT_EQ(error, "Invalid Cast URL blargh");
+}
+
+IN_PROC_BROWSER_TEST_F(CastChannelAPITest, TestOpenInvalidConnectInfo) {
+  scoped_refptr<extensions::CastChannelOpenFunction> cast_channel_open_function(
+      new extensions::CastChannelOpenFunction);
+  scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension());
+  cast_channel_open_function->set_extension(empty_extension.get());
+
+  // Invalid IP address.
+  std::string error(utils::RunFunctionAndReturnError(
+      cast_channel_open_function.get(),
+      "[{\"ipAddress\": \"invalid_ip\", \"port\": 8009, \"auth\": \"ssl\"}]",

[Wez, 2014/07/16 22:42:33]

This tests a valid ConnectInfo with invalid ipAddress; consider adding a test
for invalid ConnectInfo, e.g. one missing ipAddress, port, etc.

[mark a. foltz, 2014/07/17 19:26:51]

Done.

+      browser()));
+
+  EXPECT_EQ(error, "Invalid connect_info");
+}
+
+IN_PROC_BROWSER_TEST_F(CastChannelAPITest, TestSendInvalidMessageInfo) {
+  scoped_refptr<extensions::CastChannelSendFunction> cast_channel_send_function(
+      new extensions::CastChannelSendFunction);
+  scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension());
+  cast_channel_send_function->set_extension(empty_extension.get());
+
+  // Invalid message data - numbers are not supported
+  std::string error(utils::RunFunctionAndReturnError(
+      cast_channel_send_function.get(),
+      "[{\"channelId\": 1, \"url\": \"cast://127.0.0.1:8009\", "
+      "\"connectInfo\": "
+      "{\"ipAddress\": \"127.0.0.1\", \"port\": 8009, "
+      "\"auth\": \"ssl\"}, \"readyState\": \"open\"}, "
+      "{\"namespace_\": \"foo\", \"sourceId\": \"src\", "
+      "\"destinationId\": \"bar\", \"data\": 1235}]",
+      browser()));
+
+  EXPECT_EQ(error, "Invalid type of message_info.data");
+}