Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: src/heap/heap.cc

Issue 2554423005: [heap] Relax condition for forced finalization of incremental marking. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index c220b451c5d52bc457390ef47688495a36917c23..dbf0c8ed9aaee7b3b5e8d16fd8bbcbf9f69c66c4 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -265,7 +265,7 @@ GarbageCollector Heap::SelectGarbageCollector(AllocationSpace space,
}
if (incremental_marking()->NeedsFinalization() &&
- OldGenerationSpaceAvailable() == 0) {
+ AllocationLimitOvershotByLargeMargin()) {
*reason = "Incremental marking needs finalization";
return MARK_COMPACTOR;
}
@@ -5320,7 +5320,7 @@ bool Heap::ShouldExpandOldGenerationOnSlowAllocation() {
if (ShouldOptimizeForMemoryUsage()) return false;
if (incremental_marking()->NeedsFinalization()) {
- return false;
+ return !AllocationLimitOvershotByLargeMargin();
}
if (incremental_marking()->IsStopped() &&
« no previous file with comments | « src/heap/heap.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698