Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: components/browser_watcher/stability_report.proto

Issue 2554423002: Collect log messages from stability files (Closed)
Patch Set: Revise comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/browser_watcher/postmortem_report_collector_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 6
7 option optimize_for = LITE_RUNTIME; 7 option optimize_for = LITE_RUNTIME;
8 8
9 package browser_watcher; 9 package browser_watcher;
10 10
11 // The state of the system on which Chrome is running (shutting down, battery 11 // The state of the system on which Chrome is running (shutting down, battery
12 // level, load, etc.). 12 // level, load, etc.).
13 // Next id: 1
13 message SystemState { 14 message SystemState {
14 // TODO(manzagop): flesh out. 15 // TODO(manzagop): flesh out.
15 } 16 }
16 17
18 // Next id: 8
17 message CodeModule { 19 message CodeModule {
18 // The base address of this code module as it was loaded by the process. 20 // The base address of this code module as it was loaded by the process.
19 optional int64 base_address = 1; 21 optional int64 base_address = 1;
20 22
21 // The size of the code module. 23 // The size of the code module.
22 optional int64 size = 2; 24 optional int64 size = 2;
23 25
24 // The path or file name that the code module was loaded from. 26 // The path or file name that the code module was loaded from.
25 optional string code_file = 3; 27 optional string code_file = 3;
26 28
(...skipping 19 matching lines...) Expand all
46 optional string debug_identifier = 6; 48 optional string debug_identifier = 6;
47 49
48 // A human-readable representation of the code module's version. 50 // A human-readable representation of the code module's version.
49 optional string version = 7; 51 optional string version = 7;
50 } 52 }
51 53
52 // An activity represents information about something of interest on a thread. 54 // An activity represents information about something of interest on a thread.
53 // Next id: 9 55 // Next id: 9
54 message Activity { 56 message Activity {
55 enum Type { 57 enum Type {
56 NONE = 0; 58 UNKNOWN = 0;
57 ACT_TASK_RUN = 1; 59 ACT_TASK_RUN = 1;
58 ACT_LOCK_ACQUIRE = 2; 60 ACT_LOCK_ACQUIRE = 2;
59 ACT_EVENT_WAIT = 3; 61 ACT_EVENT_WAIT = 3;
60 ACT_THREAD_JOIN = 4; 62 ACT_THREAD_JOIN = 4;
61 ACT_PROCESS_WAIT = 5; 63 ACT_PROCESS_WAIT = 5;
62 } 64 }
63 65
64 // Identifies the type of the activity (and specifies which fields are 66 // Identifies the type of the activity (and specifies which fields are
65 // relevant). 67 // relevant).
66 optional Type type = 1; 68 optional Type type = 1;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 // Note: likely only a subset of modules of interest (e.g. Chromium's own 115 // Note: likely only a subset of modules of interest (e.g. Chromium's own
114 // modules). 116 // modules).
115 repeated CodeModule modules = 1; 117 repeated CodeModule modules = 1;
116 repeated ThreadState threads = 2; 118 repeated ThreadState threads = 2;
117 // TODO(manzagop): add experiment state. 119 // TODO(manzagop): add experiment state.
118 } 120 }
119 121
120 // A stability report contains information pertaining to the execution of a 122 // A stability report contains information pertaining to the execution of a
121 // single logical instance of a "chrome browser". It is comprised of information 123 // single logical instance of a "chrome browser". It is comprised of information
122 // about the system state and about the chrome browser's processes. 124 // about the system state and about the chrome browser's processes.
125 // Next id: 4
123 message StabilityReport { 126 message StabilityReport {
124 optional SystemState system_state = 1; 127 optional SystemState system_state = 1;
125 // TODO(manzagop): revisit whether a single repeated field should contain all 128 // TODO(manzagop): revisit whether a single repeated field should contain all
126 // processes, or whether it's preferable to have separate fields per type. 129 // processes, or whether it's preferable to have separate fields per type.
127 // TODO(manzagop): add information about the type of process, pid, process 130 // TODO(manzagop): add information about the type of process, pid, process
128 // times (e.g. start time), hierarchical relationships (e.g. parent pid), 131 // times (e.g. start time), hierarchical relationships (e.g. parent pid),
129 // command line, etc. 132 // command line, etc.
130 repeated ProcessState process_states = 2; 133 repeated ProcessState process_states = 2;
134 // TODO(manzagop): if/when reports contain multiple processes, attribute and
135 // relocate these to their process (and perhaps thread).
136 repeated string log_messages = 3;
131 } 137 }
OLDNEW
« no previous file with comments | « components/browser_watcher/postmortem_report_collector_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698