Collect log messages from stability files

components/browser_watcher/stability_report.proto

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
 package browser_watcher;
 
 // The state of the system on which Chrome is running (shutting down, battery
 // level, load, etc.).
+// Next id: 1
 message SystemState {
   // TODO(manzagop): flesh out.
 }
 
+// Next id: 8
 message CodeModule {
   // The base address of this code module as it was loaded by the process.
   optional int64 base_address = 1;
 
   // The size of the code module.
   optional int64 size = 2;
 
   // The path or file name that the code module was loaded from.
   optional string code_file = 3;
 
@@ skipping 19 matching lines @@
   optional string debug_identifier = 6;
 
   // A human-readable representation of the code module's version.
   optional string version = 7;
 }
 
 // An activity represents information about something of interest on a thread.
 // Next id: 9
 message Activity {
   enum Type {
-    NONE = 0;
+    UNKNOWN = 0;
     ACT_TASK_RUN = 1;
     ACT_LOCK_ACQUIRE = 2;
     ACT_EVENT_WAIT = 3;
     ACT_THREAD_JOIN = 4;
     ACT_PROCESS_WAIT = 5;
   }
 
   // Identifies the type of the activity (and specifies which fields are
   // relevant).
   optional Type type = 1;
@@ skipping 46 matching lines @@
   // Note: likely only a subset of modules of interest (e.g. Chromium's own
   // modules).
   repeated CodeModule modules = 1;
   repeated ThreadState threads = 2;
   // TODO(manzagop): add experiment state.
 }
 
 // A stability report contains information pertaining to the execution of a
 // single logical instance of a "chrome browser". It is comprised of information
 // about the system state and about the chrome browser's processes.
+// Next id: 4
 message StabilityReport {
   optional SystemState system_state = 1;
   // TODO(manzagop): revisit whether a single repeated field should contain all
   //     processes, or whether it's preferable to have separate fields per type.
   // TODO(manzagop): add information about the type of process, pid, process
   //     times (e.g. start time), hierarchical relationships (e.g. parent pid),
   //     command line, etc.
   repeated ProcessState process_states = 2;
+  // TODO(manzagop): if/when reports contain multiple processes, attribute and
+  //     relocate these to their process (and perhaps thread).
+  repeated string log_messages = 3;

[bcwhite, 2016/12/09 00:34:22]

I think this should not be plural given the way it's used:  add_log_message,
log_message_count, etc.  'course, that would apply to the other repeated fields,
too.

[manzagop (departed), 2016/12/09 22:41:09]

Plural is what the style guide says (not chromium's) but +1 to function name
being so-so.

 }