Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: media/cast/cast_thread.cc

Issue 25544003: Fix code style and gyp files in cast to build cast_unittest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed gyp files Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/cast_thread.h ('k') | media/cast/congestion_control/congestion_control.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/cast_thread.cc
diff --git a/media/cast/cast_thread.cc b/media/cast/cast_thread.cc
index e47446870a362da531ad526c6a802f5a7ff4c4e7..5745fb3b871486771c9b45502f3457d7336286b7 100644
--- a/media/cast/cast_thread.cc
+++ b/media/cast/cast_thread.cc
@@ -25,6 +25,8 @@ CastThread::CastThread(
DCHECK(main_thread_proxy) << "Main thread required";
}
+CastThread::~CastThread() {}
+
bool CastThread::PostTask(ThreadId identifier,
const tracked_objects::Location& from_here,
const base::Closure& task) {
@@ -57,6 +59,9 @@ scoped_refptr<TaskRunner> CastThread::GetMessageTaskRunnerForThread(
return video_encode_thread_proxy_;
case CastThread::VIDEO_DECODER:
return video_decode_thread_proxy_;
+ default:
+ CHECK(false) << "Invalid Thread ID.";
+ return NULL;
}
}
@@ -73,7 +78,8 @@ bool CastThread::CurrentlyOn(ThreadId identifier) {
case CastThread::VIDEO_DECODER:
return video_decode_thread_proxy_->RunsTasksOnCurrentThread();
default:
- DCHECK(false) << "Wrong thread identifier";
+ CHECK(false) << "Wrong thread identifier";
+ return false;
}
}
« no previous file with comments | « media/cast/cast_thread.h ('k') | media/cast/congestion_control/congestion_control.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698