Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2554393003: Add null-check for context_wrapper->context() in ForeignFetchRequestHandler. (Closed)

Created:
4 years ago by Marijn Kruisselbrink
Modified:
4 years ago
Reviewers:
michaeln
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null-check for context_wrapper->context() in ForeignFetchRequestHandler. BUG=671946 Committed: https://crrev.com/9d1da3a064450a32a8e43f16fc4e01c62aee45c1 Cr-Commit-Position: refs/heads/master@{#437052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/service_worker/foreign_fetch_request_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Marijn Kruisselbrink
4 years ago (2016-12-07 19:11:47 UTC) #4
michaeln
lgtm
4 years ago (2016-12-07 20:09:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554393003/1
4 years ago (2016-12-07 20:16:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 20:48:04 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 20:50:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d1da3a064450a32a8e43f16fc4e01c62aee45c1
Cr-Commit-Position: refs/heads/master@{#437052}

Powered by Google App Engine
This is Rietveld 408576698