Add timeouts to LoadPage and ExecJavascipt.

Add timeouts to LoadPage and ExecJavascipt.

ExecJavascriptStatement function also added to clarify how javascript is
run with Chromedriver.

BUG=669956
Committed: https://crrev.com/c7ab51d397138f491c0eeaa6ad50f320b1dcbfc4
Cr-Commit-Position: refs/heads/master@{#437025}

[Robert Ogden, 2016-12-07 17:30:15]

Description was changed from

==========
Add timeouts to LoadPage and ExecJavascipt.

ExecJavascriptStatement function also added to clarify how javascript is
run with Chromedriver.

BUG=
==========

to

==========
Add timeouts to LoadPage and ExecJavascipt.

ExecJavascriptStatement function also added to clarify how javascript is
run with Chromedriver.

BUG=669956
==========

[Robert Ogden, 2016-12-07 17:30:15]

robertogden@chromium.org changed reviewers:
+ sclittle@chromium.org

[sclittle, 2016-12-07 18:08:56]

LGTM % nit

https://codereview.chromium.org/2554383002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2554383002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:235: # TODO(crbug/672114): Use
'driver.set_script_timeout(timeout)' instead.
nit: put a username in the TODO(), and mention the crbug elsewhere in the
comment.

[Robert Ogden, 2016-12-07 18:48:22]

https://codereview.chromium.org/2554383002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2554383002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:235: # TODO(crbug/672114): Use
'driver.set_script_timeout(timeout)' instead.
On 2016/12/07 18:08:56, sclittle wrote:
> nit: put a username in the TODO(), and mention the crbug elsewhere in the
> comment.

Done.

[Robert Ogden, 2016-12-07 18:48:40]

The CQ bit was checked by robertogden@chromium.org

[Robert Ogden, 2016-12-07 18:48:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2554383002/#ps10003
(title: "Fix nit.")

[commit-bot: I haz the power, 2016-12-07 18:49:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 19:06:05]

CQ is committing da patch.

Bot data: {"patchset_id": 10003, "attempt_start_ts": 1481136520291650,
"parent_rev": "f34f01cf4eef826bc3e748aab0a893a9f797b975", "commit_rev":
"2e3f7b55ce1bd27663169c1495330492bc9588e8"}

[commit-bot: I haz the power, 2016-12-07 19:06:30]

Description was changed from

==========
Add timeouts to LoadPage and ExecJavascipt.

ExecJavascriptStatement function also added to clarify how javascript is
run with Chromedriver.

BUG=669956
==========

to

==========
Add timeouts to LoadPage and ExecJavascipt.

ExecJavascriptStatement function also added to clarify how javascript is
run with Chromedriver.

BUG=669956
==========

[commit-bot: I haz the power, 2016-12-07 19:06:31]

Committed patchset #2 (id:10003)

[commit-bot: I haz the power, 2016-12-07 19:09:32]

Description was changed from

==========
Add timeouts to LoadPage and ExecJavascipt.

ExecJavascriptStatement function also added to clarify how javascript is
run with Chromedriver.

BUG=669956
==========

to

==========
Add timeouts to LoadPage and ExecJavascipt.

ExecJavascriptStatement function also added to clarify how javascript is
run with Chromedriver.

BUG=669956

Committed: https://crrev.com/c7ab51d397138f491c0eeaa6ad50f320b1dcbfc4
Cr-Commit-Position: refs/heads/master@{#437025}
==========

[commit-bot: I haz the power, 2016-12-07 19:09:33]

Patchset 2 (id:??) landed as
https://crrev.com/c7ab51d397138f491c0eeaa6ad50f320b1dcbfc4
Cr-Commit-Position: refs/heads/master@{#437025}