Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2554383002: Add timeouts to LoadPage and ExecJavascipt. (Closed)

Created:
4 years ago by Robert Ogden
Modified:
4 years ago
Reviewers:
sclittle
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add timeouts to LoadPage and ExecJavascipt. ExecJavascriptStatement function also added to clarify how javascript is run with Chromedriver. BUG=669956 Committed: https://crrev.com/c7ab51d397138f491c0eeaa6ad50f320b1dcbfc4 Cr-Commit-Position: refs/heads/master@{#437025}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -8 lines) Patch
M tools/chrome_proxy/webdriver/common.py View 1 2 chunks +33 lines, -7 lines 0 comments Download
M tools/chrome_proxy/webdriver/simple_smoke.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Robert Ogden
4 years ago (2016-12-07 17:30:24 UTC) #3
sclittle
LGTM % nit https://codereview.chromium.org/2554383002/diff/1/tools/chrome_proxy/webdriver/common.py File tools/chrome_proxy/webdriver/common.py (right): https://codereview.chromium.org/2554383002/diff/1/tools/chrome_proxy/webdriver/common.py#newcode235 tools/chrome_proxy/webdriver/common.py:235: # TODO(crbug/672114): Use 'driver.set_script_timeout(timeout)' instead. nit: ...
4 years ago (2016-12-07 18:08:56 UTC) #4
Robert Ogden
https://codereview.chromium.org/2554383002/diff/1/tools/chrome_proxy/webdriver/common.py File tools/chrome_proxy/webdriver/common.py (right): https://codereview.chromium.org/2554383002/diff/1/tools/chrome_proxy/webdriver/common.py#newcode235 tools/chrome_proxy/webdriver/common.py:235: # TODO(crbug/672114): Use 'driver.set_script_timeout(timeout)' instead. On 2016/12/07 18:08:56, sclittle ...
4 years ago (2016-12-07 18:48:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554383002/10003
4 years ago (2016-12-07 18:49:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:10003)
4 years ago (2016-12-07 19:06:31 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 19:09:33 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7ab51d397138f491c0eeaa6ad50f320b1dcbfc4
Cr-Commit-Position: refs/heads/master@{#437025}

Powered by Google App Engine
This is Rietveld 408576698