Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 2554363002: [parsing] Add some more tests of maybe-assigned. (Closed)

Created:
4 years ago by neis
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parsing] Add some more tests of maybe-assigned. R=adamk@chromium.org, mstarzinger@chromium.org BUG= Committed: https://crrev.com/d23f8371661bd8301429e64348b361c9c036d48e Cr-Commit-Position: refs/heads/master@{#41577}

Patch Set 1 #

Patch Set 2 : format^2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -29 lines) Patch
M test/cctest/test-parsing.cc View 1 1 chunk +39 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
neis
4 years ago (2016-12-07 16:04:59 UTC) #1
adamk
lgtm
4 years ago (2016-12-07 17:39:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554363002/1
4 years ago (2016-12-08 08:15:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30227)
4 years ago (2016-12-08 08:18:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554363002/20001
4 years ago (2016-12-08 08:29:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 08:55:34 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d23f8371661bd8301429e64348b361c9c036d48e Cr-Commit-Position: refs/heads/master@{#41577}
4 years ago (2016-12-08 08:56:09 UTC) #13
Michael Starzinger
4 years ago (2016-12-08 09:45:29 UTC) #14
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698