Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2554323003: [promises] Don't allocate new array before filling up existing array (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, jgruber, caitp
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Don't allocate new array before filling up existing array Previously we created 3 FixedArrays and then filled them up with values. This meant that during the creation of the second and third FixedArray, there were one and two FixedArrays respectively, without any values in it which broke the FixedArrayVerify. This patch fills each FixedArray with the correct values before creating new ones. BUG=chromium:672051 Committed: https://crrev.com/87b84a341d06d53fbc1f189eede8b2709d864afe Cr-Commit-Position: refs/heads/master@{#41564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/builtins/builtins-promise.cc View 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
gsathya
4 years ago (2016-12-07 20:24:41 UTC) #5
Igor Sheludko
lgtm
4 years ago (2016-12-07 20:48:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554323003/1
4 years ago (2016-12-07 20:49:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 20:51:05 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-07 20:51:20 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87b84a341d06d53fbc1f189eede8b2709d864afe
Cr-Commit-Position: refs/heads/master@{#41564}

Powered by Google App Engine
This is Rietveld 408576698