Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: pkg/compiler/lib/src/enqueue.dart

Issue 2554323002: Remove ResolutionEnqueuer._applyFirstMemberUse (Closed)
Patch Set: dartfmt Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/common/backend_api.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/enqueue.dart
diff --git a/pkg/compiler/lib/src/enqueue.dart b/pkg/compiler/lib/src/enqueue.dart
index de2b4d3471bea83973eee24c0a43ee21b52bdffe..cb41939454f8b2e2fd07ef7439b1504ac7b7f426 100644
--- a/pkg/compiler/lib/src/enqueue.dart
+++ b/pkg/compiler/lib/src/enqueue.dart
@@ -219,21 +219,6 @@ class ResolutionEnqueuer extends EnqueuerImpl {
});
}
- /// Callback for applying the first seen use of a [member].
- void _applyFirstMemberUse(MemberElement member, EnumSet<MemberUse> useSet) {
- ClassElement cls = member.enclosingClass;
- if (member.isFunction) {
- MemberElement function = member;
- if (function.name == Identifiers.noSuchMethod_) {
- _registerNoSuchMethod(function);
- }
- if (function.name == Identifiers.call && !cls.typeVariables.isEmpty) {
- _registerCallMethodWithFreeTypeVariables(function);
- }
- }
- _applyMemberUse(member, useSet);
- }
-
/// Callback for applying the use of a [member].
void _applyMemberUse(Entity member, EnumSet<MemberUse> useSet) {
if (useSet.contains(MemberUse.NORMAL)) {
@@ -248,7 +233,7 @@ class ResolutionEnqueuer extends EnqueuerImpl {
void _applyClassUse(ClassEntity cls, EnumSet<ClassUse> useSet) {
if (useSet.contains(ClassUse.INSTANTIATED)) {
_recentClasses.add(cls);
- _universe.processClassMembers(cls, _applyFirstMemberUse);
+ _universe.processClassMembers(cls, _applyMemberUse);
// We only tell the backend once that [cls] was instantiated, so
// any additional dependencies must be treated as global
// dependencies.
@@ -333,12 +318,6 @@ class ResolutionEnqueuer extends EnqueuerImpl {
assert(!type.isTypeVariable || !type.element.enclosingElement.isTypedef);
}
- void _registerCallMethodWithFreeTypeVariables(Element element) {
- applyImpact(backend.registerCallMethodWithFreeTypeVariables(element,
- forResolution: true));
- _universe.callMethodsWithFreeTypeVariables.add(element);
- }
-
void _registerClosurizedMember(MemberElement element) {
assert(element.isInstanceMember);
if (element.type.containsTypeVariables) {
@@ -417,10 +396,6 @@ class ResolutionEnqueuer extends EnqueuerImpl {
_queue.add(workItem);
}
- void _registerNoSuchMethod(Element element) {
- backend.registerNoSuchMethod(element);
- }
-
/// Adds an action to the deferred task queue.
/// The action is performed the next time the resolution queue has been
/// emptied.
« no previous file with comments | « pkg/compiler/lib/src/common/backend_api.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698