CSS Motion Path: Use counter for offset-rotate

CSS Motion Path: Use counter for offset-rotate

offset-rotate now has a distinct use counter from offset-rotation.

update_use_counter_css.py has been updated to take into account the
effects of git cl format on UseCounter.cpp, where the case
and return statements are now on separate lines.

BUG=672264
Committed: https://crrev.com/0e27a9976efcea22308df3e6858e3dcd7875e068
Cr-Commit-Position: refs/heads/master@{#437228}

[Eric Willigers, 2016-12-07 06:47:32]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 06:47:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-12-07 06:49:30]

ericwilligers@chromium.org changed reviewers:
+ isherman@chromium.org

[commit-bot: I haz the power, 2016-12-07 09:01:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 09:01:19]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-12-07 22:58:33]

Description was changed from

==========
CSS Motion Path: Use counter for offset-rotate

offset-rotate now has a distinct use counter from offset-rotation.

update_use_counter_css.py has been updated to take into account the
effects of git cl format on UseCounter.cpp, where the case
and return statements are now on separate lines.


BUG=669782
==========

to

==========
CSS Motion Path: Use counter for offset-rotate

offset-rotate now has a distinct use counter from offset-rotation.

update_use_counter_css.py has been updated to take into account the
effects of git cl format on UseCounter.cpp, where the case
and return statements are now on separate lines.


BUG=672264
==========

[Eric Willigers, 2016-12-07 22:58:33]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-12-07 23:11:37]

This change should come with a test.

[Eric Willigers, 2016-12-08 00:13:21]

On 2016/12/07 23:11:37, alancutter wrote:
> This change should come with a test.

Test added.

[alancutter (OOO until 2018), 2016-12-08 00:26:54]

lgtm

[Ilya Sherman, 2016-12-08 04:52:34]

Metrics LGTM, thanks.

https://codereview.chromium.org/2554263002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/update_use_counter_css.py (right):

https://codereview.chromium.org/2554263002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/update_use_counter_css.py:55: previous_line = line
Hmm, odd.  Did the structure of the file recently change, or have people just
not been running this script and updating the histogram values manually? :-/

[Eric Willigers, 2016-12-08 05:03:56]

https://codereview.chromium.org/2554263002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/update_use_counter_css.py (right):

https://codereview.chromium.org/2554263002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/update_use_counter_css.py:55: previous_line = line
On 2016/12/08 04:52:33, Ilya Sherman wrote:
> Hmm, odd.  Did the structure of the file recently change, or have people just
> not been running this script and updating the histogram values manually? :-/

clang-format was run across Blink on Sep 30:
1c8e1a7719e9d223cc84e838c9a31a0210f5878b

text-decoration-skip was the only property added to the XML since then.
https://codereview.chromium.org/2394273006/patch/20001/30021

[Eric Willigers, 2016-12-08 05:04:07]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 05:04:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2016-12-08 05:04:33]

https://codereview.chromium.org/2554263002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/update_use_counter_css.py (right):

https://codereview.chromium.org/2554263002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/update_use_counter_css.py:55: previous_line = line
On 2016/12/08 05:03:56, Eric Willigers wrote:
> On 2016/12/08 04:52:33, Ilya Sherman wrote:
> > Hmm, odd.  Did the structure of the file recently change, or have people
just
> > not been running this script and updating the histogram values manually? :-/
> 
> clang-format was run across Blink on Sep 30:
> 1c8e1a7719e9d223cc84e838c9a31a0210f5878b
> 
> text-decoration-skip was the only property added to the XML since then.
> https://codereview.chromium.org/2394273006/patch/20001/30021

Okay, that makes sense.  Thanks!

[commit-bot: I haz the power, 2016-12-08 05:24:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 05:24:11]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eric Willigers, 2016-12-08 08:16:28]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-12-08 08:16:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 08:24:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 08:24:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eric Willigers, 2016-12-08 08:43:46]

ericwilligers@chromium.org changed reviewers:
+ mstensho@opera.com

[Eric Willigers, 2016-12-08 08:43:46]

+mstensho for core OWNERS

[mstensho (USE GERRIT), 2016-12-08 08:49:04]

Source/core/ lgtm

[Eric Willigers, 2016-12-08 09:41:16]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-12-08 09:41:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 11:08:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481190076404610,
"parent_rev": "5f75f60a415192222a6ad7079ce6d6d558600c71", "commit_rev":
"417793ea9c3f0b05bf0ea8d368e147c6d9bf563f"}

[commit-bot: I haz the power, 2016-12-08 11:09:10]

Description was changed from

==========
CSS Motion Path: Use counter for offset-rotate

offset-rotate now has a distinct use counter from offset-rotation.

update_use_counter_css.py has been updated to take into account the
effects of git cl format on UseCounter.cpp, where the case
and return statements are now on separate lines.


BUG=672264
==========

to

==========
CSS Motion Path: Use counter for offset-rotate

offset-rotate now has a distinct use counter from offset-rotation.

update_use_counter_css.py has been updated to take into account the
effects of git cl format on UseCounter.cpp, where the case
and return statements are now on separate lines.


BUG=672264
==========

[commit-bot: I haz the power, 2016-12-08 11:09:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-08 11:12:39]

Description was changed from

==========
CSS Motion Path: Use counter for offset-rotate

offset-rotate now has a distinct use counter from offset-rotation.

update_use_counter_css.py has been updated to take into account the
effects of git cl format on UseCounter.cpp, where the case
and return statements are now on separate lines.


BUG=672264
==========

to

==========
CSS Motion Path: Use counter for offset-rotate

offset-rotate now has a distinct use counter from offset-rotation.

update_use_counter_css.py has been updated to take into account the
effects of git cl format on UseCounter.cpp, where the case
and return statements are now on separate lines.

BUG=672264

Committed: https://crrev.com/0e27a9976efcea22308df3e6858e3dcd7875e068
Cr-Commit-Position: refs/heads/master@{#437228}
==========

[commit-bot: I haz the power, 2016-12-08 11:12:40]

Patchset 2 (id:??) landed as
https://crrev.com/0e27a9976efcea22308df3e6858e3dcd7875e068
Cr-Commit-Position: refs/heads/master@{#437228}