Omnibox: Highlight Matches in URLs Properly

chrome/browser/bookmarks/bookmark_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_
 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
+#include "base/strings/utf_offset_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_node_data.h"
 
 class BookmarkModel;
 class BookmarkNode;
 class Profile;
 class GURL;
 
 namespace user_prefs {
 class PrefRegistrySyncable;
 }
@@ skipping 80 matching lines @@
 void DeleteBookmarkFolders(BookmarkModel* model, const std::vector<int64>& ids);
 
 // If there are no bookmarks for url, a bookmark is created.
 void AddIfNotBookmarked(BookmarkModel* model,
                         const GURL& url,
                         const base::string16& title);
 
 // Removes all bookmarks for the given |url|.
 void RemoveAllBookmarks(BookmarkModel* model, const GURL& url);
 
-// Truncates an overly-long URL, unescapes it, and lower-cases it,
-// returning the result.  This unescaping makes it possible to match
-// substrings that were originally escaped for navigation; for
-// example, if the user searched for "a&p", the query would be escaped
-// as "a%26p", so without unescaping, an input string of "a&p" would
-// no longer match this URL.  Note that the resulting unescaped URL
-// may not be directly navigable (which is why we escaped it to begin
-// with).  |languages| is passed to net::FormatUrl().
-base::string16 CleanUpUrlForMatching(const GURL& gurl,
-                                     const std::string& languages);
+// Truncates an overly-long URL, unescapes it, and lower-cases it, returning
+// the result.  |adjustments| is set to reflect the transformations that make
+// the URL spec underwent to become the return value.  This unescaping makes

[Peter Kasting, 2014/04/23 23:18:01]

"that make the URL spec underwent"?

[Mark P, 2014/04/24 14:05:02]

Done.

Also rewrite much of the test of the comment.

+// it possible to match substrings that were originally escaped for navigation;
+// for example, if the user searched for "a&p", the query would be escaped as
+// "a%26p", so without unescaping, an input string of "a&p" would no longer
+// match this URL.  Note that the resulting unescaped URL may not be directly
+// navigable (which is why it was escaped to begin with).  |languages| is
+// passed to net::FormatUrl().
+base::string16 CleanUpUrlForMatching(
+    const GURL& gurl,
+    const std::string& languages,
+    base::OffsetAdjuster::Adjustments* adjustments);
 
 // Returns the lower-cased title, possibly truncated if the original title
 // is overly-long.
 base::string16 CleanUpTitleForMatching(const base::string16& title);
 
 }  // namespace bookmark_utils
 
 // Returns the node with |id|, or NULL if there is no node with |id|.
 const BookmarkNode* GetBookmarkNodeByID(const BookmarkModel* model, int64 id);
 
 #endif  // CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_