Omnibox: Highlight Matches in URLs Properly

chrome/browser/autocomplete/history_quick_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/history_quick_provider.h"
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 229 matching lines @@
   AutocompleteMatch match(
       this, score, !!info.visit_count(),
       history_match.url_matches().empty() ?
           AutocompleteMatchType::HISTORY_TITLE :
           AutocompleteMatchType::HISTORY_URL);
   match.typed_count = info.typed_count();
   match.destination_url = info.url();
   DCHECK(match.destination_url.is_valid());
 
   // Format the URL autocomplete presentation.
-  std::vector<size_t> offsets =
-      OffsetsFromTermMatches(history_match.url_matches());
   const net::FormatUrlTypes format_types = net::kFormatUrlOmitAll &
       ~(!history_match.match_in_scheme ? 0 : net::kFormatUrlOmitHTTP);
   match.fill_into_edit =
       AutocompleteInput::FormattedStringWithEquivalentMeaning(info.url(),

[Peter Kasting, 2014/04/23 23:18:01]

Nit: Move this onto the next line so all lines of args can start at the same
position

[Mark P, 2014/04/24 14:05:02]

Done.  Also adjusted FormatUrl() spacing around here.

-          net::FormatUrlWithOffsets(info.url(), languages_, format_types,
-              net::UnescapeRule::SPACES, NULL, NULL, &offsets));
+          net::FormatUrl(info.url(), languages_, format_types,
+              net::UnescapeRule::SPACES, NULL, NULL, NULL));
+  std::vector<size_t> offsets =
+      OffsetsFromTermMatches(history_match.url_matches());
+  base::OffsetAdjuster::Adjustments adjustments;
+  match.contents = net::FormatUrlWithAdjustments(
+      info.url(), languages_, format_types, net::UnescapeRule::SPACES, NULL,
+      NULL, &adjustments);
+  base::OffsetAdjuster::AdjustOffsets(adjustments, &offsets);
   history::TermMatches new_matches =
       ReplaceOffsetsInTermMatches(history_match.url_matches(), offsets);
-  match.contents = net::FormatUrl(info.url(), languages_, format_types,
-              net::UnescapeRule::SPACES, NULL, NULL, NULL);
   match.contents_class =
       SpansFromTermMatch(new_matches, match.contents.length(), true);
 
   // Set |inline_autocompletion| and |allowed_to_be_default_match| if possible.
-  // The second part of this test can happen if the only match(es) of the user's
-  // term occur in places FormatUrl() decides to omit in the formatted url.
-  // In these cases, it's impossible to set |inline_autocompletion| correctly
-  // and hence the match cannot be the default match.  I (mpearson@) believe
-  // this is likely caused by the mismatch that offsets are originally
-  // computed with respect to the cleaned-up URL yet then applied and
-  // updated by FormatUrl() as if they applied to the original string.
-  // See crbug.com/252630.
-  // TODO(mpearson): replacing the second clause with a DCHECK after fixing
-  // 252630.
-  if (history_match.can_inline() && !new_matches.empty()) {
+  if (history_match.can_inline()) {
+    DCHECK(!new_matches.empty());
     size_t inline_autocomplete_offset = new_matches[0].offset +
         new_matches[0].length;
     // |inline_autocomplete_offset| may be beyond the end of the
     // |fill_into_edit| if the user has typed an URL with a scheme and the
     // last character typed is a slash.  That slash is removed by the
     // FormatURLWithOffsets call above.
     if (inline_autocomplete_offset < match.fill_into_edit.length()) {
       match.inline_autocompletion =
           match.fill_into_edit.substr(inline_autocomplete_offset);
     }
@@ skipping 17 matching lines @@
   if (index_for_testing_.get())
     return index_for_testing_.get();
 
   HistoryService* const history_service =
       HistoryServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
   if (!history_service)
     return NULL;
 
   return history_service->InMemoryIndex();
 }