Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2554223002: Fix the way to check terminal field in interactive form (Closed)

Created:
4 years ago by Wei Li
Modified:
4 years ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix the way to check terminal field in interactive form Originally the key "T" was checked which was not correct since that key is optional. Now change to check "FT" as well as its parent's key since this key is also inheritable. BUG=chromium:440132 Committed: https://pdfium.googlesource.com/pdfium/+/ab5a20d9de8c801b8376bfe2d6f7cf9ac7d26028

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_interform.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M testing/SUPPRESSIONS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Wei Li
pls review, thanks
4 years ago (2016-12-07 01:35:34 UTC) #6
dsinclair
lgtm
4 years ago (2016-12-07 14:02:41 UTC) #8
dsinclair
On 2016/12/07 14:02:49, dsinclair wrote: > The CQ bit was unchecked by mailto:dsinclair@chromium.org Didn't CQ ...
4 years ago (2016-12-07 14:03:13 UTC) #10
Tom Sepez
Let's put the corpus test DEPS roll into this CL once it lands. Looks good ...
4 years ago (2016-12-07 17:16:28 UTC) #11
Wei Li
test added, suppress it on mac since the rendered image is slightly different although the ...
4 years ago (2016-12-07 19:02:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554223002/20001
4 years ago (2016-12-07 19:32:37 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-07 19:32:57 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/ab5a20d9de8c801b8376bfe2d6f7cf9ac7d2...

Powered by Google App Engine
This is Rietveld 408576698