Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2554163002: media: Add MockCdmClient (Closed)

Created:
4 years ago by xhwang
Modified:
4 years ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org, eme-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Add MockCdmClient This can be shared among multiple CDM unittests and deserve a place in mock_filters.h Also, by having a mock class, we can use StrictMock to turn uninterested mock calls into test failure, which wasn't possible with standalone MOCK_METHODs. BUG=657069 TEST=This only refactored test infrastructure. Committed: https://crrev.com/bc829a7d9755e01bf12444e6aa9c37cc074884b6 Cr-Commit-Position: refs/heads/master@{#436801}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -72 lines) Patch
M media/base/mock_filters.h View 2 chunks +37 lines, -0 lines 0 comments Download
M media/base/mock_filters.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 13 chunks +34 lines, -46 lines 1 comment Download
M media/cdm/cdm_adapter_unittest.cc View 6 chunks +15 lines, -26 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
xhwang
PTAL
4 years ago (2016-12-06 20:39:10 UTC) #2
xhwang
https://codereview.chromium.org/2554163002/diff/1/media/cdm/aes_decryptor_unittest.cc File media/cdm/aes_decryptor_unittest.cc (right): https://codereview.chromium.org/2554163002/diff/1/media/cdm/aes_decryptor_unittest.cc#newcode46 media/cdm/aes_decryptor_unittest.cc:46: MATCHER(NotEmpty, "") { IsEmpty/NotEmpty is consistent with IsNull/NotNull, and ...
4 years ago (2016-12-06 20:51:49 UTC) #3
jrummell
lgtm
4 years ago (2016-12-06 20:53:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554163002/1
4 years ago (2016-12-06 21:01:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/318478) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-06 21:04:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554163002/1
4 years ago (2016-12-06 22:39:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 00:57:33 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-07 00:59:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc829a7d9755e01bf12444e6aa9c37cc074884b6
Cr-Commit-Position: refs/heads/master@{#436801}

Powered by Google App Engine
This is Rietveld 408576698