Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: appengine/findit/templates/flake/result.html

Issue 2554143003: [Findit] Using master flake analysis key for updating triage results (Closed)
Patch Set: Addressing comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/handlers/flake/triage_flake_analysis.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/templates/flake/result.html
diff --git a/appengine/findit/templates/flake/result.html b/appengine/findit/templates/flake/result.html
index 893fa51fad9fc1c7783237b2c7efa212ba0c9cd0..79bc345fbcfd057859d43a3396350ce404ca53e8 100644
--- a/appengine/findit/templates/flake/result.html
+++ b/appengine/findit/templates/flake/result.html
@@ -55,6 +55,28 @@
findit.regressedBuildNumber = {{ suspected_flake.build_number or -1 }};
findit.passRates = {{ pass_rates | tojson | safe }};
+ function getTriageParameters(triageResult) {
+ parameters = {}
+ parameters['key'] = "{{ key }}";
+ parameters['triage_result'] = triageResult;
+ return parameters
+ }
+
+ function createTriageUrl(parameters) {
+ var params = [];
+ for(var key in parameters) {
+ if (parameters[key] != undefined) {
+ params.push(key + '=' + parameters[key])
+ }
+ }
+
+ if (params.length == 0) {
+ return '/waterfall/triage-flake-analysis'
+ } else {
+ return '/waterfall/triage-flake-analysis?' + params.join('&');
+ }
+ };
+
function DrawFlakeTrend() {
if (findit.passRates.length == 0) {
$('#flake-data').html('No data available yet.');
@@ -184,7 +206,7 @@
}
function triageSuspectedFlake(e) {
- $.getJSON('/waterfall/triage-flake-analysis?flake_info=' + e.name + '&triage_result=' + e.value, function(data) {
+ $.getJSON(createTriageUrl(getTriageParameters(e.value)), function(data) {
if (! data['success']) {
alert('Failed to update datastore. Please refresh and try again.');
} else {
@@ -252,17 +274,16 @@
<tr>
<td class="triage-cell"><a href="https://build.chromium.org/p/{{ master_name }}/builders/{{ builder_name }}/builds/{{ suspected_flake.build_number }}" target="_blank">{{ suspected_flake.build_number }}</a></a></td>
<td class="triage-cell">
- {% set flake_info = master_name + '/' + builder_name + '/' + build_number | string + '/' + step_name + '/' + test_name + '/' + version_number | string + '/' + suspected_flake.build_number | string %}
- {% if suspected_flake.triage_result == 1 %}
- <input type="radio" name="{{ flake_info }}" value="2" onchange="triageSuspectedFlake(this)">Correct &nbsp;&nbsp;
- <input type="radio" name="{{ flake_info }}" value="1" checked="checked"onchange= "triageSuspectedFlake(this)">Incorrect
- {% elif suspected_flake.triage_result == 2 %}
- <input type="radio" name="{{ flake_info }}" value="2" checked="checked" onchange="triageSuspectedFlake(this)">Correct &nbsp;&nbsp;
- <input type="radio" name="{{ flake_info }}" value="1" onchange= "triageSuspectedFlake(this)">Incorrect
- {% else %}
- <input type="radio" name="{{ flake_info }}" value="2" onchange="triageSuspectedFlake(this)">Correct &nbsp;&nbsp;
- <input type="radio" name="{{ flake_info }}" value="1" onchange= "triageSuspectedFlake(this)">Incorrect
- {% endif %}
+ {% if suspected_flake.triage_result == 1 %}
+ <input type="radio" name="triage-radio-button" value="2" onchange="triageSuspectedFlake(this)">Correct &nbsp;&nbsp;
+ <input type="radio" name="triage-radio-button" value="1" checked="checked" onchange= "triageSuspectedFlake(this)">Incorrect
+ {% elif suspected_flake.triage_result == 2 %}
+ <input type="radio" name="triage-radio-button" value="2" checked="checked" onchange="triageSuspectedFlake(this)">Correct &nbsp;&nbsp;
+ <input type="radio" name="triage-radio-button" value="1" onchange="triageSuspectedFlake(this)">Incorrect
+ {% else %}
+ <input type="radio" name="triage-radio-button" value="2" onchange="triageSuspectedFlake(this)">Correct &nbsp;&nbsp;
+ <input type="radio" name="triage-radio-button" value="1" onchange="triageSuspectedFlake(this)">Incorrect
+ {% endif %}
</td>
</tr>
</table>
« no previous file with comments | « appengine/findit/handlers/flake/triage_flake_analysis.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698