Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2413)

Unified Diff: appengine/findit/handlers/flake/test/check_flake_test.py

Issue 2554143003: [Findit] Using master flake analysis key for updating triage results (Closed)
Patch Set: Addressing comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/flake/test/check_flake_test.py
diff --git a/appengine/findit/handlers/flake/test/check_flake_test.py b/appengine/findit/handlers/flake/test/check_flake_test.py
index f921954b9715012f8be731299328ee6209e13687..8dbdf5aa4837e9a83e525e5d335ca0f8b79d39cc 100644
--- a/appengine/findit/handlers/flake/test/check_flake_test.py
+++ b/appengine/findit/handlers/flake/test/check_flake_test.py
@@ -101,6 +101,7 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
task_url = '%s/task?id=%s' % (
check_flake.SWARMING_TASK_BASE_URL, data_point.task_id)
expected_check_flake_result = {
+ 'key': analysis.key.urlsafe(),
'pass_rates': [[int(build_number), success_rate, task_url]],
'analysis_status': STATUS_TO_DESCRIPTION.get(analysis.status),
'master_name': master_name,
@@ -189,6 +190,7 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
'format': 'json'})
expected_check_flake_result = {
+ 'key': previous_analysis.key.urlsafe(),
'pass_rates': [[build_number - 1, success_rate, None]],
'analysis_status': STATUS_TO_DESCRIPTION.get(previous_analysis.status),
'master_name': master_name,
« no previous file with comments | « appengine/findit/handlers/flake/check_flake.py ('k') | appengine/findit/handlers/flake/triage_flake_analysis.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698