Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2147)

Unified Diff: content/browser/service_worker/service_worker_provider_host.h

Issue 255413005: Mostly manual refactoring of ServiceWorkerRequestHandler into a base class and two derived classes,… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.h
diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h
index 1ca21b063eafeb3599d5cc1fdba487002379b771..b4cbd906136a97cdf5b9fc470dcf502dfae8333c 100644
--- a/content/browser/service_worker/service_worker_provider_host.h
+++ b/content/browser/service_worker/service_worker_provider_host.h
@@ -20,6 +20,7 @@ namespace content {
class ServiceWorkerContextCore;
class ServiceWorkerDispatcherHost;
+class ServiceWorkerRequestHandler;
class ServiceWorkerVersion;
// This class is the browser-process representation of a serice worker
@@ -79,9 +80,10 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
// our process state. That would be indicative of a bad IPC message.
bool SetHostedVersionId(int64 versions_id);
- // Returns true if this provider host should handle requests for
- // |resource_type|.
- bool ShouldHandleRequest(ResourceType::Type resource_type) const;
+ // Returns a handler for a request, the handler may return NULL if
+ // the request doesn't require special handling.
+ scoped_ptr<ServiceWorkerRequestHandler> CreateRequestHandler(
+ ResourceType::Type resource_type);
private:
const int process_id_;

Powered by Google App Engine
This is Rietveld 408576698