Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 255413004: components: Add BUILD.gn file to metrics so we can build it with GN. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

components: Add BUILD.gn file to metrics so we can build it with GN. Debug: $ gn gen out/Debug_gn --args=is_debug=true $ ninja -C out/Debug_gn metrics Release: $ gn gen out/Release_gn --args=is_debug=false $ ninja -C out/Release_gn metrics BUG=None TEST=see above. R=brettw@chromium.org TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266675

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/metrics/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Brett -> review. Alexei -> fyi.
6 years, 8 months ago (2014-04-24 01:09:40 UTC) #1
Alexei Svitkine (slow)
On 2014/04/24 01:09:40, tfarina wrote: > Brett -> review. > > Alexei -> fyi. You ...
6 years, 8 months ago (2014-04-24 02:28:49 UTC) #2
tfarina
On 2014/04/24 02:28:49, Alexei Svitkine wrote: > On 2014/04/24 01:09:40, tfarina wrote: > > Brett ...
6 years, 8 months ago (2014-04-24 02:41:33 UTC) #3
brettw
lgtm
6 years, 8 months ago (2014-04-24 19:29:25 UTC) #4
tfarina
6 years, 7 months ago (2014-04-28 22:31:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r266675 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698