Issue 2554113003: Implement 'Import Library' Quick Fix for project libraries using TopLevelDeclarationInSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2554113003: Implement 'Import Library' Quick Fix for project libraries using TopLevelDeclarationInSource. (Closed)

Created:
4 years ago by scheglov

Modified:
4 years ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Implement 'Import Library' Quick Fix for project libraries using TopLevelDeclarationInSource. Only the current implementation is done. Implementation for the new analysis driver is not linked yet. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/57c3002ede72357ef3de3422448e215575b649b0

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -71 lines)			Patch
M	pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart	View	4 chunks	+57 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	3 chunks	+10 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	15 chunks	+43 lines, -46 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/fix_test.dart	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/analysis/top_level_declaration.dart	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/analysis/driver_test.dart	View	1 chunk	+19 lines, -9 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years ago (2016-12-06 22:24:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
57c3002ede72357ef3de3422448e215575b649b0 (presubmit successful).